Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix query builder #2773

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Sep 28, 2023

  • find tableMetadata by name instead of id
  • recursively parse query fields to build gql query fields string
  • use generated resource id path for dynamic resource details path

to test: https://preview-emx2-pr-2773.dev.molgenis.org/catalogue-demo/ssr-catalogue/VariableMappings

- find tableMetadata by name instead of id
- recursively parse query fields to build gql query fields string
@mswertz
Copy link
Member

mswertz commented Sep 29, 2023

I don't understand how it really should work, test showed me this when clicking a variablemapping

Or is this in prep of the 'identifier->name' conversion?

image

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be that I don't understand how to test so then change description and not code but I commented on an issue I encountered

@connoratrug
Copy link
Contributor Author

It might be that I don't understand how to test so then change description and not code but I commented on an issue I encountered

No i get a different result following the same link , did you test using the CI preview ?

@connoratrug connoratrug requested a review from mswertz September 29, 2023 08:06
@chinook25
Copy link
Contributor

I get the same as Morris when I click an arrow of one of the variablemappings, it does throw a console error, so that might be the problem. A steps-to-test would be nice to know what exactly to look for.

@connoratrug
Copy link
Contributor Author

added simple table view for easy testing https://preview-emx2-pr-2773.dev.molgenis.org/catalogue-demo/ssr-catalogue/tables

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@connoratrug connoratrug merged commit 0a5f26c into master Oct 11, 2023
3 checks passed
@connoratrug connoratrug deleted the fix/catalogue-resource-query-builder branch October 11, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants