Skip to content

fix (gdi): added missing profile config and updated search ui #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Aug 27, 2024

What are the main changes you did:
There were a few changes to the data model that caused the datasets search UI to break. This PR fixes that issue as well as a few other fixes

  • Adjusted GDI profile: added missing attributes and updated demo datasets to align with the latest changes of the model
  • Minor refactoring of the dataset search UI
  • Fixed typescript issues
  • Added new dev-proxy config

how to test:

  • Open the preview and sign in
  • Create a new schema using the "GDI" template and load demo data
  • In the new schema, navigate to the settings tab and add a test setting for the REMS configuration. Use these values:
    • key: REMS_URL
    • value: test or some other text
  • In the new schema, navigate to the gportal app: <schema>/gportal. Click the "Find datasets" button.

Alternatively, you can view the schema created for this PR: https://preview-emx2-pr-4166.dev.molgenis.org/gdi/gportal/#/datasets

Copy link

@davidruvolo51 davidruvolo51 marked this pull request as ready for review August 27, 2024 12:46
Copy link
Member

@joerivandervelde joerivandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the nice GUI come back to live again!

@davidruvolo51 davidruvolo51 requested a review from mswertz August 27, 2024 13:06
@davidruvolo51 davidruvolo51 merged commit 317ecc4 into master Aug 28, 2024
6 checks passed
@davidruvolo51 davidruvolo51 deleted the fix/gdi-search branch August 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants