From afa2d013439fe74544a02fd386b03a68cd7aa8ba Mon Sep 17 00:00:00 2001 From: Yossi Saadi Date: Mon, 11 Mar 2024 18:09:54 +0200 Subject: [PATCH] ci: build in the pr and release workflows, not in the "test" reusable workflow --- .github/workflows/pr.yml | 7 +++++++ .github/workflows/release.yml | 9 ++++++++- .github/workflows/test.yml | 7 ------- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 018304fe8f..acd0049419 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -5,7 +5,14 @@ on: types: [opened, synchronize] jobs: + build: + name: Build + uses: ./.github/workflows/build-and-upload.yml + secrets: + npm_token: ${{ secrets.npm_token }} + pr_checks: + needs: build uses: ./.github/workflows/test.yml secrets: npm_token: ${{ secrets.npm_token }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8261917f53..0eeba1b2df 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -3,13 +3,20 @@ name: Release new version on: workflow_dispatch jobs: + build: + name: Build + uses: ./.github/workflows/build-and-upload.yml + secrets: + npm_token: ${{ secrets.npm_token }} + prerequisites: + needs: build uses: ./.github/workflows/test.yml secrets: npm_token: ${{ secrets.npm_token }} release: - needs: prerequisites + needs: [build, prerequisites] runs-on: ubuntu-latest env: NODE_AUTH_TOKEN: ${{ secrets.npm_token }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 41562adc41..d7fa60caa2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,14 +7,7 @@ on: required: true jobs: - build: - name: Build - uses: ./.github/workflows/build-and-upload.yml - secrets: - npm_token: ${{ secrets.npm_token }} - checks: - needs: build runs-on: ubuntu-latest strategy: fail-fast: false