Skip to content

Commit efb8244

Browse files
committed
test(Modal): fix Modal's rendering in Chromatic viewport to capture all Modal and not cut it
1 parent 0fdcf9b commit efb8244

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

packages/core/src/components/Modal/Modal/__stories__/Modal.stories.helpers.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ export const OpenedModalPreview = forwardRef(
2525
const isAfterFirstRender = useAfterFirstRender();
2626
return (
2727
<div
28-
className={cx(styles.preview, getStyle(styles, size))}
28+
className={cx(styles.preview, { [getStyle(styles, size)]: isDocsView })}
2929
ref={ref}
3030
// workaround to prevent modal from autofocusing on page load
3131
// autofocus would work as expected when modal closes and reopens
3232
{...(!isAfterFirstRender.current && isDocsView && { "data-no-autofocus": true })}
3333
>
3434
<Button onClick={onOpenModalClick}>Open Modal</Button>
35-
{isDocsView ? modal : createPortal(modal, document.body)}
35+
{modal}
3636
</div>
3737
);
3838
}

packages/core/src/components/Modal/Modal/__stories__/Modal.stories.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
.preview {
88
padding-inline-start: 32px;
99
padding-block-start: 40px;
10-
height: 360px;
10+
height: 100vh;
1111
width: 100%;
1212
container-type: inline-size;
1313

packages/core/src/components/Modal/layouts/ModalBasicLayout/__stories__/ModalBasicLayout.stories.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ export default {
2929
component: Modal,
3030
subcomponents: { ModalBasicLayout, ModalHeader, ModalContent, ModalFooter, ModalFooterWizard, TransitionView },
3131
argTypes: metaSettings.argTypes,
32-
decorators: metaSettings.decorators
32+
decorators: metaSettings.decorators,
33+
parameters: {
34+
layout: "fullscreen"
35+
}
3336
} satisfies Meta<typeof Modal>;
3437

3538
export const Overview: Story = {

packages/core/src/components/Modal/layouts/ModalMediaLayout/__stories__/ModalMediaLayout.stories.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ export default {
3838
TransitionView
3939
},
4040
argTypes: metaSettings.argTypes,
41-
decorators: metaSettings.decorators
41+
decorators: metaSettings.decorators,
42+
parameters: {
43+
layout: "fullscreen"
44+
}
4245
} satisfies Meta<typeof Modal>;
4346

4447
export const Overview: Story = {

packages/core/src/components/Modal/layouts/ModalSideBySideLayout/__stories__/ModalSideBySideLayout.stories.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ export default {
4141
TransitionView
4242
},
4343
argTypes: metaSettings.argTypes,
44-
decorators: metaSettings.decorators
44+
decorators: metaSettings.decorators,
45+
parameters: {
46+
layout: "fullscreen"
47+
}
4548
} satisfies Meta<typeof Modal>;
4649

4750
export const Overview: Story = {

0 commit comments

Comments
 (0)