Skip to content

Commit 48aebf9

Browse files
authored
[PT-895] Improve Error handling in order creation process. (#96)
1 parent 5c90c87 commit 48aebf9

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

Helpers/ABTesting/ABTesting.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ public function formatApiResult($result)
1616
{
1717
$body = $result['body'];
1818

19+
if ($result['error']) {
20+
return $result;
21+
}
22+
1923
$response = [
2024
'error' => $result['error'],
2125
'message' => $result['message'],

Model/Request/Transactions.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Mondu\Mondu\Model\Ui\ConfigProvider;
1111
use Magento\Framework\UrlInterface;
1212
use Magento\Framework\Locale\Resolver;
13+
use Mondu\Mondu\Helpers\Logger\Logger as MonduFileLogger;
1314

1415
class Transactions extends CommonRequest implements RequestInterface
1516
{
@@ -58,6 +59,11 @@ class Transactions extends CommonRequest implements RequestInterface
5859
*/
5960
private $store;
6061

62+
/**
63+
* @var MonduFileLogger
64+
*/
65+
private $monduFileLogger;
66+
6167
/**
6268
* @param Curl $curl
6369
* @param CartTotalRepository $cartTotalRepository
@@ -75,7 +81,8 @@ public function __construct(
7581
OrderHelper $orderHelper,
7682
UrlInterface $urlBuilder,
7783
BuyerParamsInterface $buyerParams,
78-
Resolver $store
84+
Resolver $store,
85+
MonduFileLogger $monduFileLogger
7986
) {
8087
$this->_checkoutSession = $checkoutSession;
8188
$this->_cartTotalRepository = $cartTotalRepository;
@@ -85,6 +92,7 @@ public function __construct(
8592
$this->urlBuilder = $urlBuilder;
8693
$this->buyerParams = $buyerParams;
8794
$this->store = $store;
95+
$this->monduFileLogger = $monduFileLogger;
8896
}
8997

9098
/**
@@ -129,6 +137,10 @@ public function request($_params = []): array
129137
];
130138
}
131139
} catch (\Exception $e) {
140+
$this->monduFileLogger->error('Error while creating an order', [
141+
'message' => $e->getMessage(),
142+
'trace' => $e->getTrace()
143+
]);
132144
return [
133145
'error' => 1,
134146
'body' => null,

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "mondu_gmbh/magento2-payment",
33
"description": "Mondu payment method for magento 2",
44
"type": "magento2-module",
5-
"version": "2.3.0",
5+
"version": "2.3.1",
66
"license": [
77
"MIT"
88
],

0 commit comments

Comments
 (0)