-
Notifications
You must be signed in to change notification settings - Fork 85
feat(deps)!: upgrade mongodb driver to 7.0.0 MONGOSH-2978 #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We are upgrading the driver to 7.0.0 to detect all compilation errors. We will be fixing each compilatio error in it's specific commit.
addaleax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably want a bunch of changes from #2560 too and/or base this PR on that one – there's a bunch of stuff that's already been addressed there
Touche! I'll rebase my changes on that branch and start from there. |
| "optionalDependencies": { | ||
| "kerberos": "2.1.0", | ||
| "mongodb-client-encryption": "^6.5.0" | ||
| "kerberos": "^7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that MONGOSH-1881 on its own is already a sizable ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying for now to see where it breaks to know how to split this work in PRs that don't depend on each other (if possible). Likely for encryption and kerberos we will need other PRs.
| "kerberos": "^7.0.0", | ||
| "mongodb-client-encryption": "^7.0.0", | ||
| "bson": "^7.0.0", | ||
| "mongodb": "^7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ These additions are intended to be temporary as a way of making sure the package-lock file doesn't start hoisting other versions of these dependencies, they'll need to be removed before merging
The idea is to adapt mongosh to use the latest driver, at least, in Node.js 20. The integration with Node.js 24 will happen in another PR.