chore: use zod for arg-parser MCP-298 #2589

gagik · 2025-11-25T20:31:47Z

A couple things here (though the state has changed)

8333354 - existing behavior actually seems broken... cases like --browser=true have not been parsed correctly until now (concerning?) and the only real options have been the string-based ones. So this adds a) tests relating to this (which fail without the coercion change) and b) conditional coercing to boolean value when it is true or false. This seems to be intended behavior but let me know if I'm overlooking it.
589f446 - This switches the logic to Zod while keeping the same logic; I added some backwards compatibility tests to make sure this is correct. I kept the changes rather minimal but it'd be great to move more logic towards Zod in the future in terms of validation.

gagik · 2025-11-25T20:33:52Z

.gitignore

 snapshot.blob
 .logs/*
 !.logs/empty.xml
+mongosh.code-workspace


This is a sneak-peak into a workspace configuration I managed to do which should let Mocha Test Runner extension plug into the mongosh test setup and let us run tests in VSCode debugging UI... pending some extra config 😄

This is preparation for its usage of MCP and further changes in #2589

addaleax · 2025-11-27T14:39:26Z

packages/cli-repl/package.json

    "semver": "^7.5.4",
    "strip-ansi": "^6.0.0",
    "text-table": "^0.2.0",
-    "glibc-version": "^1.0.0",


This should remain here, no?

addaleax · 2025-11-27T14:46:29Z

package-lock.json

        "node": ">=14.15.1"
      }
    },
+    "packages/arg-parser/node_modules/zod": {


Let's make sure we can use a single, hoisted copy of zod at the top level: #2598

oh, didn't realize this was deviating from it; yeah! but would actually be better to stick to ^3.25.76 since that's what the MCP protocol SDK supports at them moment

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

addaleax

Nice work!

addaleax · 2025-11-28T15:23:24Z

packages/arg-parser/src/arg-parser.ts

+/**
+ * CLI options schema with metadata attached via registry
+ */
+export const CliOptionsSchema = z


Just a heads up, there'll be a small conflict with #2584

addaleax · 2025-11-28T15:24:01Z

packages/arg-parser/src/arg-parser.ts

+    gssapiServiceName: z.string().optional(),
+    sspiHostnameCanonicalization: z.string().optional(),
+    sspiRealmOverride: z.string().optional(),
+    jsContext: z.string().optional(),


We mark other enums as such, this one should probably be handled similarly

addaleax · 2025-11-28T15:25:21Z

packages/arg-parser/src/arg-parser.ts

+    }),
+    sslDisabledProtocols: z.string().optional().register(cliOptionsRegistry, {
+      deprecationReplacement: 'tlsDisabledProtocols',
+    }),


Wouldn't we typically want to list the non-deprecated versions here and then mention the deprecated aliases in deprecationReplacement? Feels a bit backwards to have the deprecated versions at the top level

addaleax · 2025-11-28T15:27:34Z

packages/arg-parser/src/arg-parser.ts

+    oidcDumpTokens: z
+      .union([z.boolean(), z.enum(['redacted', 'include-secrets'])])
+      .optional(),
+    browser: z.union([z.boolean(), z.string()]).optional(),


Fwiw we wouldn't want to accept true as a boolean, i.e. --browser=true should be interpreted as literally referring to the true UNIX command line utility – false is the only special value that's supposed to be interpreted as not attempting to spawn an executable at all

so we'd expect --browser to be the only way this ends up being true? and in all other cases parse it as string?
by the way we do this which I assume doesn't mean much in this case:

mongosh/packages/e2e-tests/test/e2e-oidc.spec.ts

Line 276 in dac9f72

'--browser=false',

ah okay, so false is valid but not true? Is this unique to brower or all others?

ah okay, so false is valid but not true? Is this unique to brower or all others?

Yes :)

So something like:

--browser foo ↦ { browser: "foo" }

--browser=foo ↦ { browser: "foo" }

--browser ↦ invalid, maybe error out

--browser=true ↦ { browser: "true" }

--browser=false ↦ { browser: false }

--no-browser ↦ { browser: false }

addaleax · 2025-11-28T15:28:35Z

packages/cli-repl/package.json

-    "glibc-version": "^1.0.0",
-    "text-table": "^0.2.0"
+    "text-table": "^0.2.0",
+    "glibc-version": "^1.0.0"


This is already in optionalDependencies (correctly so)

I swear npm is playing mind tricks to me I keep feeling like glic-version moves without me doing anything 😄 probably all my rebasing

Are you running .evergreen/install-npm-deps.sh by any chance? That's the only thing that I could think of that would make this happen (we mark "optional" dependencies as required there because in CI we do always want them)

gagik commented Nov 25, 2025

View reviewed changes

gagik changed the title ~~chore: use zod for arg-parser and move from cli-repl MCP-298~~ chore: use zod for arg-parser MCP-298 Nov 26, 2025

gagik force-pushed the gagik/options branch from b3d410e to b0c696f Compare November 26, 2025 16:58

gagik added a commit that referenced this pull request Nov 27, 2025

chore(arg-parser): move parseCliArgs into arg-parser

e4bbe05

This is preparation for its usage of MCP and further changes in #2589

gagik mentioned this pull request Nov 27, 2025

chore: move parseCliArgs to args-parser MCP-298 #2595

Merged

addaleax reviewed Nov 27, 2025

View reviewed changes

addaleax mentioned this pull request Nov 27, 2025

chore(snippet-manager): bump zod to 4.x #2598

Closed

gagik and others added 4 commits November 28, 2025 13:41

chore: move parseCliArgs to args-parser

09c5f4c

Apply suggestions from code review

674866f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: try nodenext

132a48d

chore: run reformat, fix build

fafa0ed

gagik force-pushed the gagik/options branch from b0c696f to 6eb90f6 Compare November 28, 2025 13:38

gagik added 2 commits November 28, 2025 14:54

chore: fix check

0d5aeb5

chore: use zod schema for arg parser

dac9f72

gagik force-pushed the gagik/options branch from 6eb90f6 to dac9f72 Compare November 28, 2025 15:18

gagik changed the base branch from main to gagik/move-arg-parser November 28, 2025 15:18

gagik marked this pull request as ready for review November 28, 2025 15:19

gagik requested a review from a team as a code owner November 28, 2025 15:19

addaleax reviewed Nov 28, 2025

View reviewed changes

Base automatically changed from gagik/move-arg-parser to main November 28, 2025 16:56

chore: use zod for arg-parser MCP-298 #2589

Are you sure you want to change the base?

chore: use zod for arg-parser MCP-298 #2589

Uh oh!

Conversation

gagik commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gagik Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gagik Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gagik commented Nov 25, 2025 •

edited

Loading

gagik Nov 28, 2025 •

edited

Loading

gagik Nov 28, 2025 •

edited

Loading