Replies: 9 comments
-
The GitHub release should be marked as prerelease if it's not a stable one. |
Beta Was this translation helpful? Give feedback.
-
I have started work on a pull request but have not implemented the part of the GitHub workflow to upload the produced firmware files, as I would like to ask for clarification on how this ought to be done. If we have a 'latest' GitHub release that would imply tagging every commit on master so that it always pointed to the latest commit. Should the script instead attach files to the last tag? (e.g. attaching |
Beta Was this translation helpful? Give feedback.
-
Maybe we can remove rojer.me and direct work with the GitHub release api? |
Beta Was this translation helpful? Give feedback.
-
thats how it was originally, but was moved to Roger.me for better controll. |
Beta Was this translation helpful? Give feedback.
-
What was the concrete reason / problem? |
Beta Was this translation helpful? Give feedback.
-
not sure was rojer decision. |
Beta Was this translation helpful? Give feedback.
-
think it was so he could control beta releases. |
Beta Was this translation helpful? Give feedback.
-
we need a plain HTTP location for stock -> HK update as stock firmware can't flash from HTTPS location (at least not from github). |
Beta Was this translation helpful? Give feedback.
-
it also makes it easier to maintain flash script. |
Beta Was this translation helpful? Give feedback.
-
Add a GitHub action to automatically build a release from master
Github release should be called 'latest'
Version should be incremented with number of commits from latest tag.
This can be taken from
git describe output
:For example, right now we are 7 commits past 2.7.0:
Current latest release should have version
2.7.0-latest7
This will ensure version check comparison during automatic update check works.
Beta Was this translation helpful? Give feedback.
All reactions