app() helper abuse

[krzysztofrewak]

Hello! I noticed that app() helper is used a lot in Monica. It's almost 150 occurences in app/Http directory and these are simple thing like this app/Http/Controllers/SettingsController.php:155:

    public function reset(Request $request)
    {
        $user = $request->user();
        $account = $user->account;

        app(ResetAccount::class)->execute([
            'account_id' => $account->id,
        ]);

        return redirect()->route('settings.index')
                    ->with('status', trans('settings.reset_success'));
    }

It could be rewritten into something more readable, custommizable and IDE-friendly:

    public function reset(Request $request, ResetAccount $resetter)
    {
        $user = $request->user();
        $account = $user->account;

        $resetter->execute([
            'account_id' => $account->id,
        ]);

        return redirect()->route('settings.index')
                    ->with('status', trans('settings.reset_success'));
    }

But I think it's sort of OK to use this on controller layer. More worrying is use of app() everywhere in services, like here, in app/Services/Account/Settings/DestroyAccount.php:65:

    private function destroyPhotos(Account $account)
    {
        app(DestroyAllPhotos::class)->execute([
            'account_id' => $account->id,
        ]);
    }

Laravel provides a very nice dependency injection management and refactored example below would be a way better approach (especially when app(DestroyAllPhotos::class) is used twice in the same class):

    private function destroyPhotos(Account $account)
    {
        $this->photosDestroyer->execute([
            'account_id' => $account->id,
        ]);
    }

There's 257 occurences total of app() in entire app directory. It's a lot, but it could be easily refactored into something more maintanable and modern. Separating service layer from Laravel-specific helpers would be fine too.

I could help with that, but I would like to confirm if that would be okay with you. I don't want to do any useless work and receive PR comment that this is against some of your internal rules or style of development. ;)

---

Btw. I'm also little worried about auth()->user() usage. There can be like 9 occurences across 15 lines in some controllers. I could help with refactoring these too. Then this:

        $search = auth()->user()->first_name.' '.
            auth()->user()->last_name.' '.
            auth()->user()->email;
        $existingContacts = Contact::search($search, auth()->user()->account_id, 'id')
            ->real()
            ->whereNotIn('id', [auth()->user()->me_contact_id])
            ->paginate(20);

        if (auth()->user()->me_contact_id) {
            $meContact = Contact::where('account_id', auth()->user()->account_id)
                ->find(auth()->user()->me_contact_id);
            $existingContacts->prepend($meContact);
        }

        $accountHasLimitations = AccountHelper::hasLimitations(auth()->user()->account);

could be little faster:

        $user = auth()->user();

        $search = $user->first_name.' '.
            $user->last_name.' '.
            $user->email;
        $existingContacts = Contact::search($search, $user->account_id, 'id')
            ->real()
            ->whereNotIn('id', [$user->me_contact_id])
            ->paginate(20);

        if ($user->me_contact_id) {
            $meContact = Contact::where('account_id', $user->account_id)
                ->find($user->me_contact_id);
            $existingContacts->prepend($meContact);
        }

        $accountHasLimitations = AccountHelper::hasLimitations($user->account);