Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert-manager last commit breaks all legends #37

Closed
sherif-fanous opened this issue Dec 18, 2023 · 3 comments
Closed

cert-manager last commit breaks all legends #37

sherif-fanous opened this issue Dec 18, 2023 · 3 comments

Comments

@sherif-fanous
Copy link

The value of all legendFormat keys in the latest commit are invalid as there are spaces between the braces

Example

https://github.com/monitoring-mixins/website/blob/b731a997db12f62dc1cab953fb97f7b867c35ecd/assets/cert-manager/dashboards/cert-manager.json#L123C16-L123C51

"legendFormat": "{ {condition } }",

should be

"legendFormat": "{{condition}}",
@haraldkoch
Copy link

I just tripped over this myself.

@ChristfriedBalizou
Copy link

This PR should fix it https://github.com/monitoring-mixins/website/pull/42/files. Also, this issue seems old. unfortunately, I suspect people just create their own files.

@v-zhuravlev
Copy link
Contributor

Hi, this issue is not present in the latest version: https://github.com/monitoring-mixins/website/blob/master/assets/cert-manager/dashboards/overview.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChristfriedBalizou @haraldkoch @v-zhuravlev @sherif-fanous