From 5b79e064f3fc629587a63da058e981718fde912d Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Tue, 11 Jun 2024 17:29:58 +0200 Subject: [PATCH] Change some links to their new docs counterparts Not much to say, all the docs pages already migrated to the new docs, point to the new ones. Plus some change from http to https. Then, the plethora of fixture changes to accommodate to the new URLs. --- remote_branch_checker/lib.php | 22 +++--- .../local_ci_fixture_all_passing.xml | 22 +++--- .../local_ci_fixture_gherkin_lint.regex | 2 +- .../local_ci_fixture_grunt_build_failed.regex | 2 +- .../local_ci_fixture_mustache_lint.regex | 2 +- .../local_ci_fixture_noncode_update.xml | 22 +++--- .../local_ci_fixture_stylelint.regex | 4 +- .../local_ci_fixture_thirdparty_css.regex | 2 +- .../MDL-54987/smurf.html | 16 ++-- .../MDL-54987/smurf.xml | 78 +++++++++---------- .../MDL-55322/smurf.html | 16 ++-- .../MDL-55322/smurf.xml | 16 ++-- 12 files changed, 102 insertions(+), 102 deletions(-) diff --git a/remote_branch_checker/lib.php b/remote_branch_checker/lib.php index 6437e952..ea7b227c 100644 --- a/remote_branch_checker/lib.php +++ b/remote_branch_checker/lib.php @@ -79,7 +79,7 @@ public function run($format, $patchset) { 'title' => 'PHP lint problems', 'abbr' => 'phplint', 'description' => 'This section shows php lint problems in the code detected by php -l', - 'url' => 'http://php.net/docs.php', + 'url' => 'https://www.php.net/docs.php', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, @@ -96,7 +96,7 @@ public function run($format, $patchset) { 'title' => 'PHP coding style problems', 'abbr' => 'phpcs', 'description' => 'This section shows the coding style problems detected in the code by phpcs', - 'url' => 'https://docs.moodle.org/dev/Coding_style', + 'url' => 'https://moodledev.io/general/development/policies/codingstyle', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1); @@ -113,7 +113,7 @@ public function run($format, $patchset) { 'title' => 'Javascript coding style problems', 'abbr' => 'js', 'description' => 'This section shows the coding style problems detected in the code by eslint', - 'url' => 'https://docs.moodle.org/dev/Javascript/Coding_style', + 'url' => 'https://moodledev.io/docs/guides/javascript', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1); @@ -131,7 +131,7 @@ public function run($format, $patchset) { 'title' => 'CSS problems', 'abbr' => 'css', 'description' => 'This section shows CSS problems detected by stylelint', - 'url' => 'https://docs.moodle.org/dev/CSS_coding_style', + 'url' => 'https://moodledev.io/docs/apis/plugintypes/theme/styles', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1); @@ -148,7 +148,7 @@ public function run($format, $patchset) { 'title' => 'PHPDocs style problems', 'abbr' => 'phpdoc', 'description' => 'This section shows the phpdocs problems detected in the code by local_moodlecheck', - 'url' => 'https://docs.moodle.org/dev/Coding_style', + 'url' => 'https://moodledev.io/general/development/policies/codingstyle#documentation-and-comments', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 3, 'warningweight' => 1); @@ -180,7 +180,7 @@ public function run($format, $patchset) { 'title' => 'Update savepoints problems', 'abbr' => 'savepoint', 'description' => 'This section shows problems detected with the handling of upgrade savepoints', - 'url' => 'https://docs.moodle.org/dev/Upgrade_API', + 'url' => 'https://moodledev.io/docs/guides/upgrade', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 50, 'warningweight' => 10); @@ -196,7 +196,7 @@ public function run($format, $patchset) { 'title' => 'Third party library modification problems', 'abbr' => 'thirdparty', 'description' => 'This section shows problems detected with the modification of third party libraries', - 'url' => 'https://docs.moodle.org/dev/Peer_reviewing#Third_party_code', + 'url' => 'https://moodledev.io/general/development/process/peer-review#third-party-code', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, @@ -213,7 +213,7 @@ public function run($format, $patchset) { 'title' => 'Missing changes in external functions or backup support for new detected tables or columns', 'abbr' => 'externalbackup', 'description' => 'This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas.', - 'url' => 'https://docs.moodle.org/dev/Peer_reviewing#The_Moodle_mobile_app', + 'url' => 'https://moodledev.io/general/development/process/peer-review#the-moodle-mobile-app', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, @@ -230,7 +230,7 @@ public function run($format, $patchset) { 'title' => 'grunt changes', 'abbr' => 'grunt', 'description' => 'This section shows files built by grunt and not commited', - 'url' => 'https://docs.moodle.org/dev/Grunt', + 'url' => 'https://moodledev.io/general/development/tools/nodejs', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, @@ -265,7 +265,7 @@ public function run($format, $patchset) { 'title' => 'Mustache template problems', 'abbr' => 'mustache', 'description' => 'This section shows problems detected in mustache templates', - 'url' => 'https://docs.moodle.org/dev/Templates', + 'url' => 'https://moodledev.io/docs/guides/templates', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, @@ -282,7 +282,7 @@ public function run($format, $patchset) { 'title' => 'Gherkin .feature problems', 'abbr' => 'gherkin', 'description' => 'This section shows problems detected in behat .feature files', - 'url' => 'https://docs.moodle.org/dev/Writing_acceptance_tests', + 'url' => 'https://moodledev.io/general/development/tools/behat/writing', 'codedir' => dirname($this->directory) . '/', 'errorweight' => 5, 'warningweight' => 1, diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml b/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml index 406a7352..67e203ef 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml @@ -20,23 +20,23 @@ This section shows the general problems detected when processing the code - + This section shows php lint problems in the code detected by php -l - + This section shows the coding style problems detected in the code by phpcs - + This section shows the coding style problems detected in the code by eslint - + This section shows CSS problems detected by stylelint - + This section shows the phpdocs problems detected in the code by local_moodlecheck @@ -44,19 +44,19 @@ This section shows the problems detected in the commit messages by the commits checker - + This section shows problems detected with the handling of upgrade savepoints - + This section shows problems detected with the modification of third party libraries - + This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. - + This section shows files built by grunt and not commited @@ -64,11 +64,11 @@ This section shows problems detected by shifter - + This section shows problems detected in mustache templates - + This section shows problems detected in behat .feature files diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex index a5412575..800b2944 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex @@ -3,7 +3,7 @@ # and its smurf.xml results. - + Feature name is already used in: mod/glossary/tests/behat/categories.feature Multiple empty lines are not allowed Wrong indentation for "and", expected indentation level of 4, but got 6 diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex index acb3ac15..b035b12e 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex @@ -3,6 +3,6 @@ # and its smurf.xml results. - + Problems running grunt Task "stylelint:scss" failed. Use --force to continue. diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex index 0e1fdddd..579c7864 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex @@ -3,7 +3,7 @@ # and its smurf.xml results. - + HTML Validation error, line 4: End tag for “body” seen, but there were unclosed elements. HTML Validation error, line 2: Unclosed element “span”. Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_noncode_update.xml b/tests/fixtures/remote_branch_checker/local_ci_fixture_noncode_update.xml index 406a7352..67e203ef 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_noncode_update.xml +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_noncode_update.xml @@ -20,23 +20,23 @@ This section shows the general problems detected when processing the code - + This section shows php lint problems in the code detected by php -l - + This section shows the coding style problems detected in the code by phpcs - + This section shows the coding style problems detected in the code by eslint - + This section shows CSS problems detected by stylelint - + This section shows the phpdocs problems detected in the code by local_moodlecheck @@ -44,19 +44,19 @@ This section shows the problems detected in the commit messages by the commits checker - + This section shows problems detected with the handling of upgrade savepoints - + This section shows problems detected with the modification of third party libraries - + This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. - + This section shows files built by grunt and not commited @@ -64,11 +64,11 @@ This section shows problems detected by shifter - + This section shows problems detected in mustache templates - + This section shows problems detected in behat .feature files diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_stylelint.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_stylelint.regex index 0a65e045..7e55c4e9 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_stylelint.regex +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_stylelint.regex @@ -9,10 +9,10 @@ - This section shows CSS problems detected by stylelint - + Expected "#EEE" to be "#eee" \(color-hex-case\) Expected single space after ":" with a single-line declaration \(declaration-colon-space-after\) Expected newline before "}" \(block-closing-brace-newline-before\) diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_thirdparty_css.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_thirdparty_css.regex index e2205dbf..dfaea35f 100644 --- a/tests/fixtures/remote_branch_checker/local_ci_fixture_thirdparty_css.regex +++ b/tests/fixtures/remote_branch_checker/local_ci_fixture_thirdparty_css.regex @@ -4,7 +4,7 @@ - + This section shows problems detected with the modification of third party libraries modification to third party library \(lib/jquery\) without update to lib/thirdpartylibs.xml or lib/jquery/readme_moodle.txt diff --git a/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.html b/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.html index 37678897..757ca6f6 100644 --- a/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.html +++ b/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.html @@ -36,9 +36,9 @@ (0/0),


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info] -


PHP coding style problems

(20 errors, 2 warnings)

This section shows the coding style problems detected in the code by phpcs +


PHP coding style problems

(20 errors, 2 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/classes/chart_axis.php
(#132) Public method name "chart_axis::jsonSerialize" must be in lower-case letters only
lib/classes/chart_bar.php
(#40) @@ -62,25 +62,25 @@ Variable "str_quotient" must not contain underscores.
(#207) Variable "str_quotient" must not contain underscores.
mod/quiz/report/overview/tests/report_test.php
(#140) Inline comments must end in full-stops, exclamation marks, or question marks
(#140) - This comment is 77% valid code; is this commented out code?




CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info] -


PHPDocs style problems

(3 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck +



Commit messages problems

(28 errors, 1 warnings)

This section shows the problems detected in the commit messages by the commits checker [More info] -

1869439
The commit message does not contain the expected issue code MDL-54987 and a space.
36bc221
The commit message does not contain the expected issue code MDL-54987 and a space.
5c9b725
The commit message does not contain the expected issue code MDL-54987 and a space.
d4377f8
The commit message does not contain the expected issue code MDL-54987 and a space.
c98ee28
The commit message does not contain the expected issue code MDL-54987 and a space.
ae34a98
The commit message does not contain the expected issue code MDL-54987 and a space.
b66c1c2
The commit message does not contain the expected issue code MDL-54987 and a space.
0deb268
The commit message does not contain the expected issue code MDL-54987 and a space.
6032c0d
The commit message does not contain the expected issue code MDL-54987 and a space.
fd44eb6
The commit message does not contain the expected issue code MDL-54987 and a space.
a01e8a5
The commit message does not contain the expected issue code MDL-54987 and a space.
ed3b416
The commit message does not contain the expected issue code MDL-54987 and a space.
37460a9
The commit message does not contain the expected issue code MDL-54987 and a space.
4046d00
The commit message does not contain the expected issue code MDL-54987 and a space.
ca3dd5d
The commit message does not contain the expected issue code MDL-54987 and a space.
3159a25
The commit message does not contain the expected issue code MDL-54987 and a space.
ee1532f
The commit message does not contain the expected issue code MDL-54987 and a space.
afe41b0
The commit message does not contain the expected issue code MDL-54987 and a space.
31d6894
The commit message does not contain the expected issue code MDL-54987 and a space.
5ef2e7b
The commit message does not contain the expected issue code MDL-54987 and a space.
7e4143f
The commit message does not contain the expected issue code MDL-54987 and a space.
2434303
The commit message does not contain the expected issue code MDL-54987 and a space.
638847c
The commit message does not contain the expected issue code MDL-54987 and a space.
743987d
The commit message does not contain the expected issue code MDL-54987 and a space.
1ca1ea7
The commit message does not contain the expected issue code MDL-54987 and a space.
244db67
The commit message does not contain the expected issue code MDL-54987 and a space.
6470f2f
The commit message does not contain the expected issue code MDL-54987 and a space.
af8ac4d
The commit message does not contain the expected issue code MDL-54987 and a space.
90a8bdbfc0082651d0a60a4396947ce9cf5d43e5...main_precheck
Too many commits (30 > 5) found. Please consider reducing it for normal patches.

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints +

1869439
The commit message does not contain the expected issue code MDL-54987 and a space.
36bc221
The commit message does not contain the expected issue code MDL-54987 and a space.
5c9b725
The commit message does not contain the expected issue code MDL-54987 and a space.
d4377f8
The commit message does not contain the expected issue code MDL-54987 and a space.
c98ee28
The commit message does not contain the expected issue code MDL-54987 and a space.
ae34a98
The commit message does not contain the expected issue code MDL-54987 and a space.
b66c1c2
The commit message does not contain the expected issue code MDL-54987 and a space.
0deb268
The commit message does not contain the expected issue code MDL-54987 and a space.
6032c0d
The commit message does not contain the expected issue code MDL-54987 and a space.
fd44eb6
The commit message does not contain the expected issue code MDL-54987 and a space.
a01e8a5
The commit message does not contain the expected issue code MDL-54987 and a space.
ed3b416
The commit message does not contain the expected issue code MDL-54987 and a space.
37460a9
The commit message does not contain the expected issue code MDL-54987 and a space.
4046d00
The commit message does not contain the expected issue code MDL-54987 and a space.
ca3dd5d
The commit message does not contain the expected issue code MDL-54987 and a space.
3159a25
The commit message does not contain the expected issue code MDL-54987 and a space.
ee1532f
The commit message does not contain the expected issue code MDL-54987 and a space.
afe41b0
The commit message does not contain the expected issue code MDL-54987 and a space.
31d6894
The commit message does not contain the expected issue code MDL-54987 and a space.
5ef2e7b
The commit message does not contain the expected issue code MDL-54987 and a space.
7e4143f
The commit message does not contain the expected issue code MDL-54987 and a space.
2434303
The commit message does not contain the expected issue code MDL-54987 and a space.
638847c
The commit message does not contain the expected issue code MDL-54987 and a space.
743987d
The commit message does not contain the expected issue code MDL-54987 and a space.
1ca1ea7
The commit message does not contain the expected issue code MDL-54987 and a space.
244db67
The commit message does not contain the expected issue code MDL-54987 and a space.
6470f2f
The commit message does not contain the expected issue code MDL-54987 and a space.
af8ac4d
The commit message does not contain the expected issue code MDL-54987 and a space.
90a8bdbfc0082651d0a60a4396947ce9cf5d43e5...main_precheck
Too many commits (30 > 5) found. Please consider reducing it for normal patches.

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info] -


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries +


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info] -


grunt changes

(3 errors, 0 warnings)

This section shows files built by grunt and not commited +



shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info] diff --git a/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.xml b/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.xml index 3f3e1b3d..93d77698 100644 --- a/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.xml +++ b/tests/fixtures/remote_branch_reporter/MDL-54987/smurf.xml @@ -38,163 +38,163 @@ - + This section shows php lint problems in the code detected by php -l - + This section shows the coding style problems detected in the code by phpcs - + Public method name "chart_axis::jsonSerialize" must be in lower-case letters only - + Line indented incorrectly; expected at least 4 spaces, found 3 - + Public method name "chart_bar::jsonSerialize" must be in lower-case letters only - + Public method name "chart_base::jsonSerialize" must be in lower-case letters only - + Protected method name "chart_base::validateAxis" must be in lower-case letters only - + Public method name "chart_line::jsonSerialize" must be in lower-case letters only - + Public method name "chart_series::jsonSerialize" must be in lower-case letters only - + Whitespace found at end of line within string - + Whitespace found at end of line within string - + Usage of ELSEIF not allowed; use ELSE IF instead - + Commas (,) must be followed by white space. - + Commas (,) must be followed by white space. - + Expected 1 space before "/"; 0 found - + Expected 1 space after "/"; 0 found - + Expected 1 space before "*"; 0 found - + Expected 1 space after "*"; 0 found - + Variable "str_quotient" must not contain underscores. - + Variable "str_quotient" must not contain underscores. - + Variable "str_quotient" must not contain underscores. - + Variable "str_quotient" must not contain underscores. - + Inline comments must end in full-stops, exclamation marks, or question marks - + This comment is 77% valid code; is this commented out code? - + This section shows the coding style problems detected in the code by eslint - + Missing JSDoc parameter type for 'horizontal'. (valid-jsdoc) - + Missing JSDoc parameter type for 'labels'. (valid-jsdoc) - + Missing JSDoc parameter type for 'smooth'. (valid-jsdoc) - + This section shows CSS problems detected by stylelint - + This section shows the phpdocs problems detected in the code by local_moodlecheck - + Phpdocs for function chart_series::set_smooth has incomplete parameters list - + Package report is not valid - + Phpdocs for function quiz_overview_report_testcase::test_get_bands_count_and_width has incomplete parameters list @@ -351,28 +351,28 @@ - + This section shows problems detected with the handling of upgrade savepoints - + This section shows problems detected with the modification of third party libraries - + This section shows files built by grunt and not commited - + Uncommitted change detected. - + Uncommitted change detected. - + Uncommitted change detected. diff --git a/tests/fixtures/remote_branch_reporter/MDL-55322/smurf.html b/tests/fixtures/remote_branch_reporter/MDL-55322/smurf.html index 16268950..f226063b 100644 --- a/tests/fixtures/remote_branch_reporter/MDL-55322/smurf.html +++ b/tests/fixtures/remote_branch_reporter/MDL-55322/smurf.html @@ -32,23 +32,23 @@ (0/0), shifter (0/0), -


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l +


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info] -


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs +


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info] -


Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint +


Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info] -


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint +


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info] -


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck +


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Commit messages problems

(0 errors, 0 warnings)

This section shows the problems detected in the commit messages by the commits checker [More info] -


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints +


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info] -


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries +


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info] -


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited +


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


- + This section shows php lint problems in the code detected by php -l - + This section shows the coding style problems detected in the code by phpcs - + This section shows the coding style problems detected in the code by eslint - + This section shows CSS problems detected by stylelint - + This section shows the phpdocs problems detected in the code by local_moodlecheck @@ -36,15 +36,15 @@ This section shows the problems detected in the commit messages by the commits checker - + This section shows problems detected with the handling of upgrade savepoints - + This section shows problems detected with the modification of third party libraries - + This section shows files built by grunt and not commited