Various changes towards CI passing with php82 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the PHP 8.2 epic (https://tracker.moodle.org/browse/MDL-76405) near being completed, it's time to verify and continuously test that everything is passing with that PHP version.
- Fixed a few php82-isms. - Changed some expectations because php lint messages are different. - Use custom fixture to test that the compare_databases job detects problems. - Restrict tests to use only 402 and master. - Added some TODOs about to use more stable branches in the future once we get more supporting php82.
|
Thanks, Eloy! |
|
Ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are running local_ci various scripts with php74 and php80, and it can be continue being used that way for years. But, as part of the PHP 8.2 Epic, where a bunch of our tools (codechecker, moodle-docker...) are modified to confirm that they work perfectly with the new PHP version, I decided to give to local_ci a run.
It has not been easy, but now it's passing and the few places in the php scripts needing fixes have been detected.
So, we are green now with php82, that's all. Achieved.
Ciao :-)