Accept component names containing numbers #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MDL-67063, the format for the plugin type part of the component names in Moodle LMS consists of a letter followed by a combination of letters and numeric characters. The changes have not been implemented in the legacy_component_name method.
|
Merged, thanks @vmdef ! This change will be auto-deployed to CiBoT in few minutes (<10min). Ciao :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MDL-67063, the format for the plugin type part of the component names in Moodle LMS consists of a letter followed by a combination of letters and numeric characters.
The changes have not been implemented in the legacy_component_name method.