Remove config sharing - ensure each hangsrc creates independent connection

Author: davegullo

src/source/imp.rs

@@ -8,22 +8,9 @@ use hang::moq_lite;
 use once_cell::sync::Lazy;
 use std::sync::LazyLock;
 use std::sync::Mutex;
-use std::collections::HashMap;
-use std::sync::Arc;
-use std::sync::atomic::{AtomicUsize, Ordering};
-
 static CAT: Lazy<gst::DebugCategory> =
 	Lazy::new(|| gst::DebugCategory::new("hang-src", gst::DebugColorFlags::empty(), Some("Hang Source Element")));
 
-#[derive(Clone)]
-struct SharedConfig {
-	tls_disable_verify: bool,
-	ref_count: Arc<std::sync::atomic::AtomicUsize>,
-}
-
-type ConfigMap = HashMap<String, SharedConfig>;
-static CONFIG_MANAGER: Lazy<Arc<Mutex<ConfigMap>>> = Lazy::new(|| Arc::new(Mutex::new(HashMap::new())));
-
 #[derive(Default, Clone)]
 struct Settings {
 	pub url: Option<String>,
@@ -35,7 +22,6 @@ struct Settings {
 pub struct HangSrc {
 	settings: Mutex<Settings>,
 	runtime: Mutex<Option<tokio::runtime::Runtime>>,
-	connection_url: Mutex<Option<String>>,
 }
 
 #[glib::object_subclass]
@@ -177,37 +163,11 @@ impl HangSrc {
 		let settings = self.settings.lock().unwrap();
 		let url = url::Url::parse(settings.url.as_ref().expect("url is required"))?;
 		let name = settings.broadcast.as_ref().expect("broadcast is required").clone();
-		let url_key = url.to_string();
-
-		// Check if we already have config for this URL
-		let tls_disable_verify = {
-			let mut configs = CONFIG_MANAGER.lock().unwrap();
-			if let Some(existing) = configs.get(&url_key) {
-				gst::info!(CAT, "Reusing existing config for URL: {}", url_key);
-				// Increment reference count
-				existing.ref_count.fetch_add(1, Ordering::SeqCst);
-				existing.tls_disable_verify
-			} else {
-				gst::info!(CAT, "Creating new config for URL: {}", url_key);
-
-				let config = SharedConfig {
-					tls_disable_verify: settings.tls_disable_verify,
-					ref_count: Arc::new(AtomicUsize::new(1)),
-				};
-
-				let tls_setting = config.tls_disable_verify;
-				configs.insert(url_key.clone(), config);
-				tls_setting
-			}
-		};
-
-		// Store the connection URL for cleanup
-		*self.connection_url.lock().unwrap() = Some(url_key);
 
 		// Create a dedicated connection for this broadcast
 		let client = moq_native::ClientConfig {
 			tls: moq_native::ClientTls {
-				disable_verify: Some(tls_disable_verify),
+				disable_verify: Some(settings.tls_disable_verify),
 				..Default::default()
 			},
 			..Default::default()
@@ -427,18 +387,5 @@ impl HangSrc {
 
 	fn cleanup(&self) {
 		// TODO kill spawned tasks
-
-		// Cleanup config reference
-		if let Some(url_key) = self.connection_url.lock().unwrap().take() {
-			let mut configs = CONFIG_MANAGER.lock().unwrap();
-			if let Some(config) = configs.get(&url_key) {
-				let ref_count = config.ref_count.fetch_sub(1, Ordering::SeqCst);
-				if ref_count == 1 {
-					// This was the last reference, remove the config
-					gst::info!(CAT, "Removing config for URL: {}", url_key);
-					configs.remove(&url_key);
-				}
-			}
-		}
 	}
 }