OriginConsumer::announced panics if prefix does not match

[roberte777]

I wanted to check if this behavior was expected. If it is not expected, I am more than happy to open a PR to solve.

I was hoping to use with_root to filter out broadcasts from other roots. However, if a broadcast is announced and it does not have the root / prefix that I defined, there is an unwrap that gets hit. My expectation is that this announcement would be filtered out instead.

let mut announcements = self
    .consumer
    .with_root(&prefix)
    .ok_or_else(|| RpcError::Moq(format!("prefix '{prefix}' not authorized")))?;

match announcements.announced().await {
// some logic
}

thread 'main' (6564335) panicked at /Users/ethan.wilkes/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/moq-lite-0.12.0/src/model/origin.rs:37:60:
called `Option::unwrap()` on a `None` value

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Related PRs

#642 - Fix cluster prefix removal. [merged]

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[kixelated]

That absolutely is not supposed to panic. I'm a bit surprised that it does because I rely on that functionality.

[kixelated]

Can you make a unit test that panics? Claude is having a bit of trouble reproducing without knowing how you set up the producer and consumer.

[roberte777]

#[test]
async fn test_announce_panic() {
	let origin = Origin::produce();

	// Use an owned String so the trailing slash is NOT normalized away.
	let prefix = "some_prefix/".to_string();
	let mut consumer1 = origin.consume().with_root(prefix).unwrap();

	let b = origin.create_broadcast("some_prefix/test").unwrap();
	consumer1.assert_next("test", &b.consume());
}

Ah, I didn't realize I was putting the trailing slash there. I'm not sure how that affects what you want to do in this case, still probably shouldn't panic even though this is me being dumb.