From 1717ed8d5779a81c38fa2a59129a853b085918ee Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Feb 2026 09:18:26 -0800 Subject: [PATCH 1/2] require_equals --- rs/moq-native/src/client.rs | 1 + rs/moq-native/src/iroh.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/rs/moq-native/src/client.rs b/rs/moq-native/src/client.rs index fcbd3591a..d53228a00 100644 --- a/rs/moq-native/src/client.rs +++ b/rs/moq-native/src/client.rs @@ -28,6 +28,7 @@ pub struct ClientTls { env = "MOQ_CLIENT_TLS_DISABLE_VERIFY", default_missing_value = "true", num_args = 0..=1, + require_equals = true, value_parser = clap::value_parser!(bool), )] pub disable_verify: Option, diff --git a/rs/moq-native/src/iroh.rs b/rs/moq-native/src/iroh.rs index a51c40f44..22491c7a1 100644 --- a/rs/moq-native/src/iroh.rs +++ b/rs/moq-native/src/iroh.rs @@ -20,6 +20,7 @@ pub struct IrohEndpointConfig { env = "MOQ_IROH_ENABLED", default_missing_value = "true", num_args = 0..=1, + require_equals = true, value_parser = clap::value_parser!(bool), )] pub enabled: Option, From e9cce33e44755c8ce069e6c23686a365bc1c68ce Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Feb 2026 11:53:24 -0800 Subject: [PATCH 2/2] Fix the tests. --- rs/moq-native/src/client.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/rs/moq-native/src/client.rs b/rs/moq-native/src/client.rs index d53228a00..9d263dfb2 100644 --- a/rs/moq-native/src/client.rs +++ b/rs/moq-native/src/client.rs @@ -353,10 +353,16 @@ mod tests { #[test] fn test_cli_disable_verify_explicit_false() { - let config = ClientConfig::parse_from(["test", "--tls-disable-verify", "false"]); + let config = ClientConfig::parse_from(["test", "--tls-disable-verify=false"]); assert_eq!(config.tls.disable_verify, Some(false)); } + #[test] + fn test_cli_disable_verify_explicit_true() { + let config = ClientConfig::parse_from(["test", "--tls-disable-verify=true"]); + assert_eq!(config.tls.disable_verify, Some(true)); + } + #[test] fn test_cli_no_disable_verify() { let config = ClientConfig::parse_from(["test"]);