Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Composer compatible with Python 3.12. #3658

Open
antoinebrl opened this issue Oct 18, 2024 · 4 comments
Open

Make Composer compatible with Python 3.12. #3658

antoinebrl opened this issue Oct 18, 2024 · 4 comments
Labels
enhancement New (engineering) enhancements, such as features or API changes.

Comments

@antoinebrl
Copy link
Contributor

🚀 Motivation

Since 2.4 released ~3 months ago PyTorch is officially supporting Python 3.12 (the torch.compile was a bit lagging behind due to changes in the CPython interface). It would be great to see Py3.12 being supported in Composer too.
@antoinebrl antoinebrl added the enhancement New (engineering) enhancements, such as features or API changes. label Oct 18, 2024
@mvpatel2000
Copy link
Contributor

Will likely be in next release :)

@b-chu
Copy link
Contributor

b-chu commented Oct 21, 2024

We're seeing difficulties with upgrading to Python 3.12 with torchvision dependencies so will hold off for this release.
https://github.com/mosaicml/composer/actions/runs/11414612796

@antoinebrl
Copy link
Contributor Author

Thanks @b-chu for having a look and reporting on your investigation! 👍 Should this issue to reopened to track the adoption of py3.12 ?

@mvpatel2000 mvpatel2000 reopened this Oct 28, 2024
@mvpatel2000
Copy link
Contributor

Concretely, we are blocked on upgrading until triton fixes some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New (engineering) enhancements, such as features or API changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mvpatel2000 @antoinebrl @b-chu