Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout metrics are six orders of magnitude too long #315

Closed
hho opened this issue Dec 16, 2024 · 11 comments · Fixed by #316
Closed

Timeout metrics are six orders of magnitude too long #315

hho opened this issue Dec 16, 2024 · 11 comments · Fixed by #316
Assignees
@hho
Labels
🐛 Bug Something isn't working

Comments

@hho
Copy link
Contributor

hho commented Dec 16, 2024

As explained in the FAQ, the timeout values are configured in nanoseconds.
And it works: When I set batchTimeout to 500e6 I get 500ms of timeout.

However, the metric reported after the test says:

kafka_writer_batch_timeout.........: 138h53m20s  min=138h53m20s  max=138h53m20s

which equates to 500000 seconds. So the given metric is 1000000× too large.

I believe the same applies to kafka_writer_read_timeout and kafka_writer_write_timeout.
@mostafa
Copy link
Owner

mostafa commented Dec 16, 2024

Hey @hho,

Thanks for reporting this issue. This looks like a conversion issue between Go and JS values. If you have time to look into the code, it'd be great. Otherwise, I need to find some time to do it.

@hho hho mentioned this issue Dec 16, 2024
Merged
@hho
Copy link
Contributor Author

hho commented Dec 16, 2024

TBH I'm struggling to learn Go, but I think found it (#316).

(I've also adapted the tests, not sure if you want those changes too?)

@mostafa
Copy link
Owner

mostafa commented Dec 18, 2024

@hho The tests pass, so I think we can leave it. Thanks for spotting this issue and fixing it! 🙏

@mostafa mostafa added the 🐛 Bug Something isn't working label Dec 18, 2024
@mostafa mostafa moved this to Test in xk6-kafka Dec 18, 2024
@hho
Copy link
Contributor Author

hho commented Dec 20, 2024

@mostafa Somehow the new release still shows this bug, but if I build the v0.29.0 tag myself it's fixed…

Could it be there's something wrong with the build? It seems like it just downloaded an earlier build instead of rebuilding it?
Again, I'm not really knowledgeable in Go, but maybe this line in the build is missing the =. at the end?

@mostafa mostafa reopened this Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Test to Doing in xk6-kafka Dec 20, 2024
@mostafa
Copy link
Owner

mostafa commented Dec 20, 2024

@hho This is strange. I'll see if I can reproduce this on my machine. Are you using arm64 or amd64 builds?

@mostafa
Copy link
Owner

mostafa commented Dec 20, 2024

@hho Can you also give me an snippet of the script you use to test? (please redact sensitive information before posting)

@mostafa
Copy link
Owner

mostafa commented Dec 20, 2024

I used this command to build the executable on my machine:

GOOS=darwin GOARCH=arm64 xk6 build --output xk6-kafka --with github.com/mostafa/xk6-kafka@v0.29.0

And this is the result of running ./xk6-kafka version:

xk6-kafka v0.55.0 (go1.23.3, darwin/arm64)
Extensions:
  github.com/mostafa/xk6-kafka v0.29.0, k6/x/kafka [js]

@hho
Copy link
Contributor Author

hho commented Dec 20, 2024

I'm using linux/amd64. You can reproduce it with the included test_string.js script for example.

Using the downloaded release binary 
hho@hho-pc: ~/devel/xk6-kafka (main %=)
➜ sha256sum ~/Downloads/dist/xk6-kafka_v0.29.0_linux_amd64 
3d1d36dbf02409f76e2e4aa9a6c58237289273b391b0c4ffedfd3980d89b630b  /home/hho/Downloads/dist/xk6-kafka_v0.29.0_linux_amd64

➜ ~/Downloads/dist/xk6-kafka_v0.29.0_linux_amd64 --version
xk6-kafka_v0.29.0_linux_amd64 v0.55.0 (go1.23.4, linux/amd64)
Extensions:
  github.com/mostafa/xk6-kafka v0.29.0, k6/x/kafka [js]


➜ ~/Downloads/dist/xk6-kafka_v0.29.0_linux_amd64 run scripts/test_string.js 

         /\      Grafana   /‾‾/  
    /\  /  \     |\  __   /  /   
   /  \/    \    | |/ /  /   ‾‾\ 
  /          \   |   (  |  (‾)  |
 / __________ \  |_|\_\  \_____/ 

     execution: local
        script: scripts/test_string.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 1 iterations for each of 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     ✓ 10 messages are received
     ✓ Topic equals to xk6_kafka_json_topic
     ✓ Key is a string and is correct
     ✓ Value is a string and is correct
     ✓ Header equals {'mykey': 'myvalue'}
     ✓ Time is past
     ✓ Partition is zero
     ✓ Offset is gte zero
     ✓ High watermark is gte zero

     checks.............................: 100.00%     9 out of 9
     data_received......................: 0 B         0 B/s
     data_sent..........................: 0 B         0 B/s
     iteration_duration.................: avg=46.66ms  min=46.66ms  med=46.66ms  max=46.66ms  p(90)=46.66ms  p(95)=46.66ms 
     iterations.........................: 1           12.039984/s
     kafka_reader_dial_count............: 1           12.039984/s
     kafka_reader_dial_seconds..........: avg=3.17ms   min=3.17ms   med=3.17ms   max=3.17ms   p(90)=3.17ms   p(95)=3.17ms  
   ✓ kafka_reader_error_count...........: 0           0/s
     kafka_reader_fetch_bytes...........: 2.9 kB      35 kB/s
     kafka_reader_fetch_bytes_max.......: 1000000     min=1000000     max=1000000    
     kafka_reader_fetch_bytes_min.......: 1           min=1           max=1          
     kafka_reader_fetch_size............: 45          541.799298/s
     kafka_reader_fetch_wait_max........: 10s         min=10s         max=10s        
     kafka_reader_fetches_count.........: 2           24.079969/s
     kafka_reader_lag...................: 0           min=0           max=0          
     kafka_reader_message_bytes.........: 1.4 kB      17 kB/s
     kafka_reader_message_count.........: 45          541.799298/s
     kafka_reader_offset................: 45          min=45          max=45         
     kafka_reader_queue_capacity........: 100         min=100         max=100        
     kafka_reader_queue_length..........: 35          min=35          max=35         
     kafka_reader_read_seconds..........: avg=152.74µs min=152.74µs med=152.74µs max=152.74µs p(90)=152.74µs p(95)=152.74µs
     kafka_reader_rebalance_count.......: 0           0/s
     kafka_reader_timeouts_count........: 0           0/s
     kafka_reader_wait_seconds..........: avg=1.73ms   min=1.73ms   med=1.73ms   max=1.73ms   p(90)=1.73ms   p(95)=1.73ms  
     kafka_writer_acks_required.........: 0           min=0           max=0          
     kafka_writer_async.................: 0.00%       0 out of 100
     kafka_writer_attempts_max..........: 10          min=10          max=10         
     kafka_writer_batch_bytes...........: 6.9 kB      83 kB/s
     kafka_writer_batch_max.............: 1           min=1           max=1          
     kafka_writer_batch_queue_seconds...: avg=12.36µs  min=2.98µs   med=10.17µs  max=128.51µs p(90)=17.89µs  p(95)=21.88µs 
     kafka_writer_batch_seconds.........: avg=62.09µs  min=14.24µs  med=45.11µs  max=1.78ms   p(90)=67.31µs  p(95)=74.16µs 
     kafka_writer_batch_size............: 100         1203.99844/s
     kafka_writer_batch_timeout.........: 277h46m40s  min=277h46m40s  max=277h46m40s 
   ✓ kafka_writer_error_count...........: 0           0/s
     kafka_writer_message_bytes.........: 14 kB       166 kB/s
     kafka_writer_message_count.........: 200         2407.996881/s
     kafka_writer_read_timeout..........: 2777h46m40s min=2777h46m40s max=2777h46m40s
     kafka_writer_retries_count.........: 0           0/s
     kafka_writer_wait_seconds..........: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     kafka_writer_write_count...........: 200         2407.996881/s
     kafka_writer_write_seconds.........: avg=68.77µs  min=18µs     med=53µs     max=1.73ms   p(90)=72.72µs  p(95)=83.18µs 
     kafka_writer_write_timeout.........: 2777h46m40s min=2777h46m40s max=2777h46m40s


running (00m00.1s), 0/1 VUs, 1 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m00.0s/10m0s  1/1 iters, 1 per VU

Note for example the 2777h46m40s given for kafka_writer_write_timeout in the last line of the metrics – so it's still showing the bug!

Rebuilding the checked out code 
➜ git checkout v0.29.0 
HEAD is now at 33e895e Fix Trivy

➜ xk6 build --with github.com/mostafa/xk6-kafka@v0.29.0=.
2024/12/20 16:10:40 [INFO] Temporary folder: /tmp/buildenv_2024-12-20-1610.3668943611
2024/12/20 16:10:40 [INFO] Initializing Go module
2024/12/20 16:10:40 [INFO] exec (timeout=10s): /usr/local/go/bin/go mod init k6 
go: creating new go.mod: module k6
2024/12/20 16:10:40 [INFO] Replace github.com/mostafa/xk6-kafka => /home/hho/devel/xk6-kafka
2024/12/20 16:10:40 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod edit -replace github.com/mostafa/xk6-kafka=/home/hho/devel/xk6-kafka 
2024/12/20 16:10:40 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
go: warning: "all" matched no packages
2024/12/20 16:10:40 [INFO] Pinning versions
2024/12/20 16:10:40 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
go: found github.com/mostafa/xk6-kafka in github.com/mostafa/xk6-kafka v0.0.0-00010101000000-000000000000
go: finding module for package github.com/onsi/ginkgo
go: found github.com/onsi/ginkgo in github.com/onsi/ginkgo v1.16.5
2024/12/20 16:10:41 [INFO] Writing main module: /tmp/buildenv_2024-12-20-1610.3668943611/main.go
2024/12/20 16:10:41 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
2024/12/20 16:10:41 [INFO] Build environment ready
2024/12/20 16:10:41 [INFO] Building k6
2024/12/20 16:10:41 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
2024/12/20 16:10:41 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/hho/devel/xk6-kafka/k6 -ldflags=-w -s -trimpath 
2024/12/20 16:10:41 [INFO] Build complete: ./k6
2024/12/20 16:10:41 [INFO] Cleaning up temporary folder: /tmp/buildenv_2024-12-20-1610.3668943611

xk6 has now produced a new k6 binary which may be different than the command on your system path!
Be sure to run './k6 run <SCRIPT_NAME>' from the '/home/hho/devel/xk6-kafka' directory.

➜ sha256sum ./k6
177757ae76c7c156ad49936a7ca0d42d20e2bb194b78113f7336c1f8ff790323  ./k6

➜ ./k6 --version
k6 v0.55.0 (go1.23.4, linux/amd64)
Extensions:
  github.com/mostafa/xk6-kafka (devel), k6/x/kafka [js]


➜ ./k6 run scripts/test_string.js 

         /\      Grafana   /‾‾/  
    /\  /  \     |\  __   /  /   
   /  \/    \    | |/ /  /   ‾‾\ 
  /          \   |   (  |  (‾)  |
 / __________ \  |_|\_\  \_____/ 

     execution: local
        script: scripts/test_string.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 1 iterations for each of 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     ✓ 10 messages are received
     ✓ Topic equals to xk6_kafka_json_topic
     ✓ Key is a string and is correct
     ✓ Value is a string and is correct
     ✓ Header equals {'mykey': 'myvalue'}
     ✓ Time is past
     ✓ Partition is zero
     ✓ Offset is gte zero
     ✓ High watermark is gte zero

     checks.............................: 100.00% 9 out of 9
     data_received......................: 0 B     0 B/s
     data_sent..........................: 0 B     0 B/s
     iteration_duration.................: avg=54.62ms  min=54.62ms  med=54.62ms  max=54.62ms  p(90)=54.62ms  p(95)=54.62ms 
     iterations.........................: 1       11.129134/s
     kafka_reader_dial_count............: 1       11.129134/s
     kafka_reader_dial_seconds..........: avg=3.57ms   min=3.57ms   med=3.57ms   max=3.57ms   p(90)=3.57ms   p(95)=3.57ms  
   ✓ kafka_reader_error_count...........: 0       0/s
     kafka_reader_fetch_bytes...........: 4.1 kB  46 kB/s
     kafka_reader_fetch_bytes_max.......: 1000000 min=1000000   max=1000000
     kafka_reader_fetch_bytes_min.......: 1       min=1         max=1      
     kafka_reader_fetch_size............: 64      712.264592/s
     kafka_reader_fetch_wait_max........: 10s     min=10s       max=10s    
     kafka_reader_fetches_count.........: 2       22.258268/s
     kafka_reader_lag...................: 0       min=0         max=0      
     kafka_reader_message_bytes.........: 2.0 kB  23 kB/s
     kafka_reader_message_count.........: 64      712.264592/s
     kafka_reader_offset................: 64      min=64        max=64     
     kafka_reader_queue_capacity........: 100     min=100       max=100    
     kafka_reader_queue_length..........: 54      min=54        max=54     
     kafka_reader_read_seconds..........: avg=151.63µs min=151.63µs med=151.63µs max=151.63µs p(90)=151.63µs p(95)=151.63µs
     kafka_reader_rebalance_count.......: 0       0/s
     kafka_reader_timeouts_count........: 0       0/s
     kafka_reader_wait_seconds..........: avg=1.58ms   min=1.58ms   med=1.58ms   max=1.58ms   p(90)=1.58ms   p(95)=1.58ms  
     kafka_writer_acks_required.........: 0       min=0         max=0      
     kafka_writer_async.................: 0.00%   0 out of 100
     kafka_writer_attempts_max..........: 10      min=10        max=10     
     kafka_writer_batch_bytes...........: 6.9 kB  77 kB/s
     kafka_writer_batch_max.............: 1       min=1         max=1      
     kafka_writer_batch_queue_seconds...: avg=14.74µs  min=6.93µs   med=12.81µs  max=118.2µs  p(90)=19.75µs  p(95)=22.99µs 
     kafka_writer_batch_seconds.........: avg=75.95µs  min=35.26µs  med=54.8µs   max=1.74ms   p(90)=85.18µs  p(95)=94.35µs 
     kafka_writer_batch_size............: 100     1112.913425/s
     kafka_writer_batch_timeout.........: 1s      min=1s        max=1s     
   ✓ kafka_writer_error_count...........: 0       0/s
     kafka_writer_message_bytes.........: 14 kB   154 kB/s
     kafka_writer_message_count.........: 200     2225.82685/s
     kafka_writer_read_timeout..........: 10s     min=10s       max=10s    
     kafka_writer_retries_count.........: 0       0/s
     kafka_writer_wait_seconds..........: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     kafka_writer_write_count...........: 200     2225.82685/s
     kafka_writer_write_seconds.........: avg=84.98µs  min=41.35µs  med=64.55µs  max=1.76ms   p(90)=93.27µs  p(95)=104.35µs
     kafka_writer_write_timeout.........: 10s     min=10s       max=10s    


running (00m00.1s), 0/1 VUs, 1 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m00.1s/10m0s  1/1 iters, 1 per VU

Now the bug is fixed (timeout correctly shown as 10s).

Rebuilding from the v0.29.0 go module 
hho@hho-pc: ~/devel/xk6-kafka ((tags/v0.29.0^0) %)
➜ xk6 build --with github.com/mostafa/xk6-kafka@v0.29.0
2024/12/20 16:12:57 [INFO] Temporary folder: /tmp/buildenv_2024-12-20-1612.1790263367
2024/12/20 16:12:57 [INFO] Initializing Go module
2024/12/20 16:12:57 [INFO] exec (timeout=10s): /usr/local/go/bin/go mod init k6 
go: creating new go.mod: module k6
2024/12/20 16:12:57 [INFO] Pinning versions
2024/12/20 16:12:57 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod edit -require github.com/mostafa/xk6-kafka@v0.29.0 
2024/12/20 16:12:57 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
go: finding module for package github.com/onsi/ginkgo
go: found github.com/onsi/ginkgo in github.com/onsi/ginkgo v1.16.5
2024/12/20 16:12:57 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
2024/12/20 16:12:57 [INFO] Writing main module: /tmp/buildenv_2024-12-20-1612.1790263367/main.go
2024/12/20 16:12:57 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
2024/12/20 16:12:58 [INFO] Build environment ready
2024/12/20 16:12:58 [INFO] Building k6
2024/12/20 16:12:58 [INFO] exec (timeout=0s): /usr/local/go/bin/go mod tidy -compat=1.17 
2024/12/20 16:12:58 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/hho/devel/xk6-kafka/k6 -ldflags=-w -s -trimpath 
2024/12/20 16:12:59 [INFO] Build complete: ./k6
2024/12/20 16:12:59 [INFO] Cleaning up temporary folder: /tmp/buildenv_2024-12-20-1612.1790263367

xk6 has now produced a new k6 binary which may be different than the command on your system path!
Be sure to run './k6 run <SCRIPT_NAME>' from the '/home/hho/devel/xk6-kafka' directory.

hho@hho-pc: ~/devel/xk6-kafka ((tags/v0.29.0^0) %)
➜ sha256sum ./k6
3d1d36dbf02409f76e2e4aa9a6c58237289273b391b0c4ffedfd3980d89b630b  ./k6

hho@hho-pc: ~/devel/xk6-kafka ((tags/v0.29.0^0) %)
➜ ./k6 --version
k6 v0.55.0 (go1.23.4, linux/amd64)
Extensions:
  github.com/mostafa/xk6-kafka v0.29.0, k6/x/kafka [js]


hho@hho-pc: ~/devel/xk6-kafka ((tags/v0.29.0^0) %)
➜ ./k6 run scripts/test_string.js 

         /\      Grafana   /‾‾/  
    /\  /  \     |\  __   /  /   
   /  \/    \    | |/ /  /   ‾‾\ 
  /          \   |   (  |  (‾)  |
 / __________ \  |_|\_\  \_____/ 

     execution: local
        script: scripts/test_string.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 1 iterations for each of 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     ✓ 10 messages are received
     ✓ Topic equals to xk6_kafka_json_topic
     ✓ Key is a string and is correct
     ✓ Value is a string and is correct
     ✓ Header equals {'mykey': 'myvalue'}
     ✓ Time is past
     ✓ Partition is zero
     ✓ Offset is gte zero
     ✓ High watermark is gte zero

     checks.............................: 100.00%     9 out of 9
     data_received......................: 0 B         0 B/s
     data_sent..........................: 0 B         0 B/s
     iteration_duration.................: avg=51.64ms  min=51.64ms  med=51.64ms  max=51.64ms  p(90)=51.64ms  p(95)=51.64ms 
     iterations.........................: 1           11.576101/s
     kafka_reader_dial_count............: 1           11.576101/s
     kafka_reader_dial_seconds..........: avg=3.89ms   min=3.89ms   med=3.89ms   max=3.89ms   p(90)=3.89ms   p(95)=3.89ms  
   ✓ kafka_reader_error_count...........: 0           0/s
     kafka_reader_fetch_bytes...........: 5.3 kB      62 kB/s
     kafka_reader_fetch_bytes_max.......: 1000000     min=1000000     max=1000000    
     kafka_reader_fetch_bytes_min.......: 1           min=1           max=1          
     kafka_reader_fetch_size............: 83          960.816413/s
     kafka_reader_fetch_wait_max........: 10s         min=10s         max=10s        
     kafka_reader_fetches_count.........: 2           23.152203/s
     kafka_reader_lag...................: 0           min=0           max=0          
     kafka_reader_message_bytes.........: 2.7 kB      31 kB/s
     kafka_reader_message_count.........: 83          960.816413/s
     kafka_reader_offset................: 83          min=83          max=83         
     kafka_reader_queue_capacity........: 100         min=100         max=100        
     kafka_reader_queue_length..........: 73          min=73          max=73         
     kafka_reader_read_seconds..........: avg=188.15µs min=188.15µs med=188.15µs max=188.15µs p(90)=188.15µs p(95)=188.15µs
     kafka_reader_rebalance_count.......: 0           0/s
     kafka_reader_timeouts_count........: 0           0/s
     kafka_reader_wait_seconds..........: avg=1.91ms   min=1.91ms   med=1.91ms   max=1.91ms   p(90)=1.91ms   p(95)=1.91ms  
     kafka_writer_acks_required.........: 0           min=0           max=0          
     kafka_writer_async.................: 0.00%       0 out of 100
     kafka_writer_attempts_max..........: 10          min=10          max=10         
     kafka_writer_batch_bytes...........: 6.9 kB      80 kB/s
     kafka_writer_batch_max.............: 1           min=1           max=1          
     kafka_writer_batch_queue_seconds...: avg=13.82µs  min=2.8µs    med=11.14µs  max=166.64µs p(90)=16.44µs  p(95)=20.67µs 
     kafka_writer_batch_seconds.........: avg=65.14µs  min=14.98µs  med=50.34µs  max=1.27ms   p(90)=69.86µs  p(95)=85.25µs 
     kafka_writer_batch_size............: 100         1157.610137/s
     kafka_writer_batch_timeout.........: 277h46m40s  min=277h46m40s  max=277h46m40s 
   ✓ kafka_writer_error_count...........: 0           0/s
     kafka_writer_message_bytes.........: 14 kB       160 kB/s
     kafka_writer_message_count.........: 200         2315.220273/s
     kafka_writer_read_timeout..........: 2777h46m40s min=2777h46m40s max=2777h46m40s
     kafka_writer_retries_count.........: 0           0/s
     kafka_writer_wait_seconds..........: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     kafka_writer_write_count...........: 200         2315.220273/s
     kafka_writer_write_seconds.........: avg=73.52µs  min=17.62µs  med=61.42µs  max=1.27ms   p(90)=82.07µs  p(95)=103.85µs
     kafka_writer_write_timeout.........: 2777h46m40s min=2777h46m40s max=2777h46m40s


running (00m00.1s), 0/1 VUs, 1 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m00.1s/10m0s  1/1 iters, 1 per VU

Building without the =. module redirect seems to reuse an older version of the module. Note how the produced binary is the exact same as in the released files. Consequently, the bug is showing again. I believe this is what happened in the CI build too, when the release was made (and that's why the binary hashes are identical).

When you check the list of builds, you see that the v0.29.0 tag was built 4 times, with different commit hashes! The first one is from last month, and that's probably the one being used.

@hho
Copy link
Contributor Author

hho commented Dec 20, 2024

OK, I've read up a bit on Go modules… It's indeed like I thought: The module github.com/mostafa/xk6-kafka@v0.29.0 was published in November already: https://proxy.golang.org/github.com/mostafa/xk6-kafka/@v/v0.29.0.info

Later updating the tag does not change the published module anymore, as explained on the Go blog:

Do not delete version tags from your repo. If you find a bug or a security issue with a version, release a new version. If people depend on a version that you have deleted, their builds may fail. Similarly, once you release a version, do not change or overwrite it. The module mirror and checksum database store modules, their versions, and signed cryptographic hashes to ensure that the build of a given version remains reproducible over time.

This is why xk6 build now downloads and uses the old version, unless you explicitly specify the local directory.

@hho hho closed this as completed Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Doing to Test in xk6-kafka Dec 20, 2024
@mostafa
Copy link
Owner

mostafa commented Dec 21, 2024

I'll fix it.

@mostafa
Copy link
Owner

mostafa commented Dec 21, 2024

https://github.com/mostafa/xk6-kafka/releases/tag/v0.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hho hho

Labels
🐛 Bug Something isn't working
Projects
xk6-kafka
Status: Test
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix writer timeout metrics hho/xk6-kafka
2 participants
@mostafa @hho