Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified gitignore to avoid tracking .DS_Store MacOS files and also r… #2705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

utkarshanand140
Copy link

Fixes a part of #871
Replaced unnecessary strings with characters to make compilation faster.
Also modified the .gitignore file to avoid tracking .DS_Store files which are often generated when working on MacOS systems.

…eplacing unecessary strings with characters types for faster compilations
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. Can you try to fix it everywhere rather than partially? There was an abandoned PR that attempted the same you could pick up and bring over the finish line

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d962501) to head (b06593c).
Report is 33 commits behind head on main.

Files Patch % Lines
...t_core/collision_detection/src/collision_tools.cpp 0.00% 1 Missing ⚠️
...oveit_setup_srdf_plugins/src/group_meta_config.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2705       +/-   ##
==========================================
- Coverage   50.74%   0.00%   -50.73%     
==========================================
  Files         392     672      +280     
  Lines       32553   56718    +24165     
  Branches        0    7247     +7247     
==========================================
- Hits        16517       0    -16517     
- Misses      16036   56718    +40682     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utkarshanand140
Copy link
Author

Thanks for these changes. Can you try to fix it everywhere rather than partially? There was an abandoned PR that attempted the same you could pick up and bring over the finish line

Yes sure, I'll be happy to complete it.

Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added stale Inactive issues and PRs are marked as stale and may be closed automatically. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Apr 19, 2024
Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break these changes out into two PRs - I'd be happy to approve and merge the .gitignore change separately from the code changes.

Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants