Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Simple Image be rendered? The doc listes it but there is no show in my browser. #79

Open
searich opened this issue Apr 14, 2023 · 4 comments

Comments

@searich
Copy link

searich commented Apr 14, 2023

Purpose

  • New feature
  • New renderer
  • Bug fix
  • Documentation
  • Refactoring
  • Test Case
  • Other

Description

Possible solution

@lightningspirit
Copy link
Contributor

Hi @searich sorry for the late response.
It certainly does as of the latest release, but I can have a look to see if the API changed in EditorJS.
What version are you using?

@sachin-tcd
Copy link

sachin-tcd commented Jun 13, 2023

I am having the same issue.
My editorjs version is 2.26.5

@phungvansyhb
Copy link

phungvansyhb commented Sep 5, 2023

i face the same issue, and i must use custom renderers

const SimpleImageRenderer: RenderFn<{
    stretched : boolean ,
    withBackground:boolean ,
    withBorder : boolean,
    caption : string ,
    url : string
}> = ({
          data, className = "" ,
      }) => {

    return (
            <img fetchPriority={'low'}  alt={data.caption} className={'object-contain'} src={ data.url } />
    )
}

@Anish-Aby
Copy link

Anish-Aby commented Jan 26, 2024

I was facing the same issue. However, looking back into my code, I was using both image and simpleImage. When we configure both image and simpleImage, the output for simple image "type" will be "simpleImage" and not "image". Since we do not have any renderers for "simpleImage", that was the issue causing a problem for me. I can open a PR with the new renderer if the owner is still maintaining the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants