Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create try pushes for old phabricator revisions #2124

Open
Tracked by #2273
jcristau opened this issue Mar 21, 2024 · 8 comments · Fixed by #2471
Open
Tracked by #2273

don't create try pushes for old phabricator revisions #2124

jcristau opened this issue Mar 21, 2024 · 8 comments · Fixed by #2471
Assignees
Labels
teklia-2024 Issue for Teklia work in 2024

Comments

@jcristau
Copy link
Contributor

If reviewbot fails to create a try push for a given phabricator revision in some time (1 hour?), it should give up instead of holding on to it forever.

We're seeing an issue right now where reviewbot is delayed making try pushes by 2 days.

@marco-c
Copy link
Collaborator

marco-c commented Mar 21, 2024

@marco-c
Copy link
Collaborator

marco-c commented Mar 21, 2024

We should return a failure and post to Phab that we run out of time.

@La0
Copy link
Collaborator

La0 commented Oct 21, 2024

  • we should check the age of the build there as there are other stop conditions
  • the age is obtainable through PhabricatorBuild.diff.[some path in JSON]

@La0
Copy link
Collaborator

La0 commented Oct 24, 2024

Side note: we need this patch to test deployment of #2449 (if we need to get some downtime, it will spam with try pushes otherwise)

@marco-c
Copy link
Collaborator

marco-c commented Oct 24, 2024

This is fixed in libmozevent, we just need to upgrade the lib.

@La0
Copy link
Collaborator

La0 commented Nov 25, 2024

The usage of this patch in events gives this Sentry issue

@La0
Copy link
Collaborator

La0 commented Nov 26, 2024

I made a cleaner version of build expiry check, adding a new state on the build, and custom error messages.

These 2 PRs still require some unit tests

@La0
Copy link
Collaborator

La0 commented Dec 6, 2024

@Archaeopteryx could you review mozilla/libmozevent#109 then we need to build a libmozevent release (should just be a tag push) and use it in #2550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teklia-2024 Issue for Teklia work in 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants