Skip to content
This repository has been archived by the owner on Jan 4, 2021. It is now read-only.

No capability to handle 'Repeat Password'. #177

Open
b4handjr opened this issue Dec 7, 2017 · 3 comments
Open

No capability to handle 'Repeat Password'. #177

b4handjr opened this issue Dec 7, 2017 · 3 comments

Comments

@b4handjr
Copy link
Collaborator

b4handjr commented Dec 7, 2017

Every now-and-then this comes up, it would be nice if it didn't allow the login to fail.

@davehunt
Copy link
Member

davehunt commented Dec 7, 2017

Do we know what causes this to come up? I agree we should support this, though it would be nice if we could determine the circumstances that cause it.

@rfk
Copy link

rfk commented Dec 7, 2017

Do we know what causes this to come up?

Sorry, it's an experiment that you get randomly bucketed into. Off the top of my head, the only way I can think of to make this more stable, would be to coerce localStorage["__fxa_storage.uniqueUserId"] to a known value so that we bucket you into the same set of experiments every time (at least until the set of experiments changes anyway).

@davehunt
Copy link
Member

davehunt commented Dec 8, 2017

That's okay, we're not testing FxA with this package, so I think it's acceptable to have a short wait to see if the additional password request appears. As this will incur a penalty when we're not challenged for the password a second time, we should keep this as short as possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants