Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remember my decision for this site" doesn't remember decision to override default container #1730

Open
mattrossman opened this issue May 2, 2020 · 39 comments
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container

Comments

@mattrossman
Copy link

mattrossman commented May 2, 2020

  • Multi-Account Containers Version: 6.2.5
  • Operating System + Version: Windows 10 Education
  • Firefox Version: 75.0
  • Other installed Add-ons + Version + Enabled/Disabled-Status: Switch Container Plus v0.19

Actual behavior

Every time I navigate to Google Drive from a "Personal" container when "School" is set as the default, the extension asks me if I really want to do that, even when I tell it to remember my decision.

Expected behavior

After telling the extension to "remember my decision for this site", it will stop asking my permission to override the default container I set for that site.

Just to make the use case clear:

Most of the time I want to use my "School" account. So when I open up a new tab (which will start in the blank container) and go to Google Drive, it should switch to my "School" container. But there are still lots of times that I want to use my "Personal" account, so if I open up a "Personal" tab and go to Google Drive, it should just stay in my "Personal" container!

Steps to reproduce

  1. Navigate to a site in container A
  2. In the add-on, check "Always open in container A"
  3. Open up a new tab in container B
  4. Navigate to the same site
  5. When the extension asks, "Open this site in your assigned container?" check "Remember my decision for this site" and then click "Open in container B"
  6. Open a new tab in container B and navigate to the same site
  7. The same screen will appear asking for your permission

Notes

I know the base/blank container is titled "Default", but when I say default container I mean the container a site will default to.

I feel like this is almost worth a feature request for a less aggressive "Always open in" setting. Maybe the current behavior works for some people, but as a user I expect the following behavior:

I want this site to open in container A by default, but if I explicitly navigate there from container B, then open the site in container B!

It seems pretty hard to accidentally open a container tab, so I don't get why it's so insistent on double checking that I actually want to use that container.

@Solid-Ice8
Copy link

Solid-Ice8 commented May 2, 2020

From the design of the add-on, only "one site" can be "remembered" in a container at a time. You can visit the site in multiple containers, but it will "always remember this site in this container".

No cross-overs of website assignment in containers. Every container has its own unique "storage session". This is what allows users to use multiple accounts on various websites and this is also what protects the users from trackers and/or potential hijackers and what not. Facebook & Google are well known for tracking everything you do and everywhere you go.

The purpose of MA-C is to block this type of tracking. If you sign into Google, they can only see the activities you do in that specific "storage session". They will not be able to track what you're doing outside the container. They can only track what sites you've been on inside that container.

If you're on GitHub and using Google's container, yup they are tracking you.

Unless you separate it. Assign 'GitHub' to "X" container. Boom, Google can't track you. This is outside their "storage session'. X container is a new storage session.

We all have personal and private things in life, and of course they overlap. Imagine this

Personal (School/Work) | Private
abc                    | def

This works with containers & tracking too. You don't want any private things into personal right? and vice versa right?

The reason they don't allow this crossover is because if you assign "FaceBook.com" into both Personal & Private containers, FaceBook will know this is indeed only "one person".

Container's "divide" identities. With individual containers, they see 2 different users, not one.

Sounds like you use Personal Google account for School use as well. (I could be wrong). I used to use one FireFox Profile for everything too, both Personal and Private use...and then I learned to use multiple FireFoxes.

If it helps, you can use an add-on like "Containers theme". it'll switch colours to whatever container you're on.

@mattrossman
Copy link
Author

mattrossman commented May 2, 2020

Hey @Solid-Ice8 thanks for the response, but I think there's some misunderstanding. I have two separate Google accounts, one for School and one for Personal. Each is signed into their respective container with separate cookies. I'm not asking for cross-overs of website information, I'm talking about behavior of the optional "Always open in" feature in the add-on menu. The existing implementation already lets me do what I want, just in too many steps.

If I go to https://drive.google.com from a new tab, I want to be switched to my School container (i.e. school account) because that's what I use most often. However, if I explicitly open a Personal container tab (I now intend to use my personal identity), then when I go to https://drive.google.com it should let me stay in that container so I can access my personal account. 2 different Google accounts for 2 different containers. I don't have any account signed in on the "Default" container, so every time I open a new tab and go to https://drive.google.com it takes me to the landing page to register, which gets annoying real quick. Or if I check "Always open in container School", then it will now properly redirect my "Default" container tabs, but my "Personal" container tabs always require me to confirm my choice.

Again, the add-on already lets you do what I want, I'm just asking for them to make it easier.

@Solid-Ice8
Copy link

I see, maybe a built-in feature like FireFox itself. "Switch Container Tab"?

@mattrossman
Copy link
Author

mattrossman commented May 2, 2020

I feel like "Default to container A" most clearly describes what I want, because the only intervention it should enforce is "Default" --> "A" (literally, from default to A). Or perhaps after clicking "Always open in container A" it could show a dropdown to pick either "From any container" or "From default container" so you can choose how strict it should be.

In any case, they need to fix the wording or behavior of "Remember my decision for this site". In every other UI out there, "Remember my decision" means "Stop asking me this question", but in the current state of the add-on it doesn't stop asking unless you pick the blue button.

@Cavein
Copy link

Cavein commented May 26, 2020

Even having a way to clear all of the "Open this site in your assigned container?" settings in one go would be a nice feature. I keep getting prompted for https://calendar.google.com/calendar/ and no matter if I have "Remember my decision for this site" it will keep prompting me every single time telling me that I've asked it to open in my old container (it doesn't seem to save the settings at all). If it can't save the new container setting for that site, it would be nice to have the option to remove that setting entirely so it stops prompting me. It's quite annoying.

@ankur-lt
Copy link

Any update here?

@adrianiepure
Copy link

This behavior still has not been resolved and "Remember my decision for this site" continues to be a useless checkbox.

@Nakiami
Copy link

Nakiami commented Sep 8, 2021

+1 for this one. Unfortunately making this addon very annoying to use as it asks each time I visit for example youtube.

@rybchynski
Copy link

+1
A checkbox that does nothing.

@DylanGraham
Copy link

I had to delete the container it kept prompting about to make it stop

@jcreigh
Copy link

jcreigh commented Dec 17, 2021

If it can't save the new container setting for that site, it would be nice to have the option to remove that setting entirely so it stops prompting me. It's quite annoying.

I had same situation. Here's how I've found to manually reset it for a site (tested in Nightly)

Go to about:debugging -> This Firefox -> Click Inspect on the addon (or go to about:devtools-toolbox?id=%40testpilot-containers&type=extension directly)

Go to Extension Storage and simply delete the entry associated with the site (will probably have to expand the Key column to see which it is)

That's it :)

@achernyakevich-sc
Copy link

Go to about:debugging -> This Firefox -> Click Inspect on the addon (or go to about:devtools-toolbox?id=%40testpilot-containers&type=extension directly)

Go to Extension Storage and simply delete the entry associated with the site (will probably have to expand the Key column to see which it is)

That's it :)

@jcreigh this way to stop opening in default container is really a "programmers way". :) There is some simple from container configuration UI. See detailed in #2173 (comment)

@jcreigh
Copy link

jcreigh commented Dec 20, 2021

@achernyakevich-sc

There is some simple from container configuration UI.

I clicked through to the issue linked in that issue and then was finally able to find it by right clicking on the page once I open the website in the container.

That is... rather unintuitive. I had tried right clicking on all the other container related stuff to no effect, went through all my settings and menus and found nothing, unless I'm blind. Literally never thought to look in the context menu there. :s

Ah well, my google-fu failed to find the other issues :) Glad there's a slightly less clunky way I can use next time. Thanks

@achernyakevich-sc
Copy link

@jcreigh Sorry, for the case that link I provided reference to many possibilities to achieve result that require many clicks and analysis. :)

To simplify for all who will check this issue comments, below there are few direct instructions (you could use any of these):

  • on the page open in the target container call context menu (right click) and you will get menu like here - just untick Aways Open in This Container.
  • click to MAC button on toolbar -> in opened UI click Manage Containers -> then click to your container (in your case it looks like it should be Shopping container) -> in opened UI click Manage Sites List... -> find URL of site that you would like to do not always open in the container and click bin icon. Close configuration window and restart Firefox.

@0xFlo
Copy link

0xFlo commented Jan 13, 2023

Every time I search something with the browser bar it asks where I want to open it because somehow the whole google domain is "remembered" to always ask me and there is no way to remove it because the plugin doesn't have any settings. This is ridiculous.

@0xFlo
Copy link

0xFlo commented Jan 13, 2023

On macos there is no MAC button on the toolbar:
click to MAC button on toolbar -> in opened UI click Manage Containers
The context menu is also empty for this extension

@achernyakevich-sc
Copy link

On macos there is no MAC button on the toolbar: click to MAC button on toolbar -> in opened UI click Manage Containers The context menu is also empty for this extension

@0xFlo Probably you either removed it by right click to toolbar and click to Customize Toolbar... or it is is hidden in collapsed menu on right of toolbar like Firefox View on my screenshot (my MAC button I moved to other part of toolbar so it is not visible on the screenshot):
image

@achernyakevich-sc
Copy link

Meanwhile... more details instruction is available in other issue.

@magnusja
Copy link

This is driving me crazy

@0xFlo
Copy link

0xFlo commented Jan 26, 2023 via email

@alekmlynek
Copy link

Yep. 2023, and this still needs to be fixed. I love the plug-in, but this is almost a deal breaker. Every time I click anything, "Do you want to open in........????"

Just go away. I don't need an extra click on every interaction. Remember my decision, or just default to the standard container until I tell you otherwise. Sorry, this turned into a bit of a rant!

@0xFlo
Copy link

0xFlo commented Mar 17, 2023 via email

@gravelfreeman
Copy link

This is so annoying I can't believe this is still a thing in 2023. Just get rid of this extra screen no matter what it takes/cost/whatever. Remove this entirely.

@maxtar
Copy link

maxtar commented Aug 31, 2023

@jcreigh Sorry, for the case that link I provided reference to many possibilities to achieve result that require many clicks and analysis. :)

To simplify for all who will check this issue comments, below there are few direct instructions (you could use any of these):

* on the page open in the target container call context menu (right click) and you will get [menu like here](https://github.com/mozilla/multi-account-containers/issues/2104#issuecomment-898814043) - just untick `Aways Open in This Container`.

* click to MAC button on toolbar -> in opened UI click `Manage Containers` -> then click to your container (in your case it looks like it should be `Shopping` container) -> in opened UI click `Manage Sites List...` -> find URL of site that you would like to do not always open in the container and click bin icon. Close configuration window and restart Firefox.

Didn't work for me. After deleting all unneeded links. And reopen browser all deleted links restored.

@achernyakevich-sc
Copy link

@maxtar Probably after restart it get restored settings because you have settings synchronization turned on. You could try to turn sync off and try again after that.

@maxtar
Copy link

maxtar commented Sep 1, 2023

@maxtar Probably after restart it get restored settings because you have settings synchronization turned on. You could try to turn sync off and try again after that.

Yes, I have enabled synchronization. But I need it.

@achernyakevich-sc
Copy link

Then you could temporary turn off the Sync, take sure that problem is not reproduce and if it is so then address problem to the Sync issue (please search the corresponding one in this repository). As I could guess problem could be related to wrong time set on your workstations - syncing local workstation's time with internet time could solve the problem.

@maxtar
Copy link

maxtar commented Sep 3, 2023

Then you could temporary turn off the Sync, take sure that problem is not reproduce and if it is so then address problem to the Sync issue (please search the corresponding one in this repository). As I could guess problem could be related to wrong time set on your workstations - syncing local workstation's time with internet time could solve the problem.

Will try.
But time synchronized via internet.

@maxtar
Copy link

maxtar commented Sep 3, 2023

@achernyakevich-sc looks like after disabling synchronization, deleting sites from container and restart browser it works.
But why need restarting browser? This is not obviously behavior.

@achernyakevich-sc
Copy link

@maxtar "restarting browser" I took from your comment:

Didn't work for me. After deleting all unneeded links. And reopen browser all deleted links restored.

So I included it to the test case to localize possible root of problem. So as it works when synchronization is turned off it just confirm that issues is not related to "Remember my decision for this site" feature but the most probably it is related to Synchronization. :)

@14790897
Copy link

14790897 commented Mar 3, 2024

@jcreigh Sorry, for the case that link I provided reference to many possibilities to achieve result that require many clicks and analysis. :)

To simplify for all who will check this issue comments, below there are few direct instructions (you could use any of these):

  • on the page open in the target container call context menu (right click) and you will get menu like here - just untick Aways Open in This Container.
  • click to MAC button on toolbar -> in opened UI click Manage Containers -> then click to your container (in your case it looks like it should be Shopping container) -> in opened UI click Manage Sites List... -> find URL of site that you would like to do not always open in the container and click bin icon. Close configuration window and restart Firefox.

It works for me

@gravelfreeman
Copy link

I did that as well but it's eventually coming back again. Either by sync or because of the Firefox Home Page button. It would be great that the add-on could customize the Firefox Home Page button link per profile so it would stop from happening.

@ltachev-r3
Copy link

ltachev-r3 commented Mar 15, 2024

This is annoying as hell and I can not believe the level of decision making and management in software business these days .. people are complaining for years and some bot tries to explain to me "you are using it wrong - go and fkn do 10 clicks for 100 sites one by one in order to turn Off something I never asked for or never turned on ever" .. sorry to say that, but this is a
completely idiotic UI design .. just add a general option "enable assign URL to container" or whatever, that will be Off by default and whoever wants this functionality can go and turn On in extensions settings, simple as this

@achernyakevich-sc
Copy link

@ltachev-r3 It is not a business, it is open source. :)

You can implement it for your own and publish here as Pull Request. Or... will you pay me to get it implemented? so it will become business.

@ltachev-r3
Copy link

ltachev-r3 commented Mar 15, 2024

@ltachev-r3 It is not a business, it is open source. :)

You can implement it for your own and publish here as Pull Request. Or... will you pay me to get it implemented? so it will become business.

An official Mozilla extension is not a business .. Ok..

@gravelfreeman
Copy link

It's been 4 years this ticket has been brought up. The sync breaks the whole thing everytime for me. All the runarounds in the thread didn't last. Can someone take this seriously and make a PR. PLEASE!

@tealsnow
Copy link

tealsnow commented Jun 19, 2024

Please try to fix this in an otherwise great extension.

I open a GitHub link one time from an email in a container now every time I open GitHub in a new tab regardless of the origin's container it asks me if it should open this site in 'its assigned container' and every time I click the box to remember my decision and pick the default container. But alas, it has no memory.

Edit:
There is a pr to fix this ready for review as of 3 weeks ago #2617. Can someone please review and merge it?

@dungphan8x
Copy link

dungphan8x commented Sep 1, 2024

on May 2, 2020

Yet another year.

@boumanb
Copy link

boumanb commented Sep 1, 2024

Fixed by this PR #2649 maybe?

Also see the following issue #2263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container
Projects
None yet
Development

Successfully merging a pull request may close this issue.