-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SASS stylesheet #5
Comments
I agree that we need gulp/grunt, because we will need more things in the future like minimization, packaging and even signing. No doubt. About SASS, I don't know :) If you feel confident and @erick-bolinaga can help with this (the CSS is made by him, and I don't know if he knows SASS), let's do it. About BEM-style, see above :) |
Let's hear @erick-bolinaga opinion but in any case the use of SCSS will be mainly to take advantage of nesting. There's no need to "learn SASS" in this case. |
@willyaranda I should probably email @erick-bolinaga, right? |
Yeah, better 😀
|
@willyaranda I just added a gulpfile to the master branch by mistake (damn remotes!). I can rollback and make a PR anyway if needed. |
I don't know SASS or SCSS. Some of you could do it, if it is required. |
The thing here is to organize the CSS by namespace, like We won't be using any SASS feature, just nesting. I can do this and the you can review it. |
@fjaguero sounds cool, please ask us for review once you have it! |
Ok, working on in! 🚀 |
I will not be prioritizing this by now. |
As plain CSS gets complex while adding more views, we should start using a pre-processor to have each view organized. By separating the CSS it will be easier to work as everything will be modularized.
Proposal
I can port/optimize the current CSS to SCSS and add a gulpfile that will handle the compilation. We can use node-sass to avoid the ruby version. The drawback is that not all the features are implemented but that won't be a problem in this case since it will be really straightforward.
Extra spicy
What do you think of using BEM-style for the classes. Why? This makes long-term readability and assures no spaghetti CSS. This is not a must but I recommend it.
The text was updated successfully, but these errors were encountered: