Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SASS stylesheet #5

Open
fjaguero opened this issue Sep 8, 2014 · 10 comments
Open

Add SASS stylesheet #5

fjaguero opened this issue Sep 8, 2014 · 10 comments
Labels

Comments

@fjaguero
Copy link
Member

fjaguero commented Sep 8, 2014

As plain CSS gets complex while adding more views, we should start using a pre-processor to have each view organized. By separating the CSS it will be easier to work as everything will be modularized.

Proposal

I can port/optimize the current CSS to SCSS and add a gulpfile that will handle the compilation. We can use node-sass to avoid the ruby version. The drawback is that not all the features are implemented but that won't be a problem in this case since it will be really straightforward.

Extra spicy

What do you think of using BEM-style for the classes. Why? This makes long-term readability and assures no spaghetti CSS. This is not a must but I recommend it.

@willyaranda
Copy link
Member

I agree that we need gulp/grunt, because we will need more things in the future like minimization, packaging and even signing. No doubt.

About SASS, I don't know :) If you feel confident and @erick-bolinaga can help with this (the CSS is made by him, and I don't know if he knows SASS), let's do it.

About BEM-style, see above :)

@fjaguero
Copy link
Member Author

fjaguero commented Sep 9, 2014

Let's hear @erick-bolinaga opinion but in any case the use of SCSS will be mainly to take advantage of nesting. There's no need to "learn SASS" in this case.

@fjaguero
Copy link
Member Author

@willyaranda I should probably email @erick-bolinaga, right?

@fjaguero fjaguero self-assigned this Sep 10, 2014
@willyaranda
Copy link
Member

Yeah, better 😀
El 10/09/2014 22:24, "Fernando Agüero" notifications@github.com escribió:

@willyaranda https://github.com/willyaranda I should probably email
@erick-bolinaga https://github.com/erick-bolinaga, right?


Reply to this email directly or view it on GitHub
#5 (comment).

@fjaguero
Copy link
Member Author

@willyaranda I just added a gulpfile to the master branch by mistake (damn remotes!). I can rollback and make a PR anyway if needed.

@erick-bolinaga
Copy link
Contributor

I don't know SASS or SCSS. Some of you could do it, if it is required.

@fjaguero
Copy link
Member Author

The thing here is to organize the CSS by namespace, like .timeline-view .class, .dm-view .class, etc.

We won't be using any SASS feature, just nesting. I can do this and the you can review it.

@willyaranda
Copy link
Member

@fjaguero sounds cool, please ask us for review once you have it!

@fjaguero
Copy link
Member Author

Ok, working on in! 🚀

@fjaguero
Copy link
Member Author

I will not be prioritizing this by now.

@fjaguero fjaguero removed their assignment Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants