Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin crashes for Jekyll >= 1.1.0 #13

Open
matze opened this issue Aug 14, 2013 · 4 comments · May be fixed by #14
Open

Plugin crashes for Jekyll >= 1.1.0 #13

matze opened this issue Aug 14, 2013 · 4 comments · May be fixed by #14

Comments

@matze
Copy link

matze commented Aug 14, 2013

The static_comments.rb plugin crashes with

$ jekyll serve --trace
Configuration file: /home/matthias/blog/_config.yml
            Source: /home/matthias/blog
       Destination: /home/matthias/blog/_site
      Generating... /var/lib/gems/1.8/gems/jekyll-1.1.2/bin/../lib/jekyll/post.rb:255:in `to_liquid': wrong number of arguments (1 for 0) (ArgumentError)

with Jekyll version 1.1.0 and 1.1.2. Versions 1.0.0 through 1.0.4 work fine.

My gut tells me it's that change that leads to the problem.

@kctong529
Copy link

I have exactly the same problem. I use Jekyll version 1.2.1.

@IQAndreas IQAndreas linked a pull request Sep 28, 2013 that will close this issue
@IQAndreas
Copy link
Contributor

If either of you are still having problems with it, making it compatible is actually a really simple fix: IQAndreas@ce7808d

The plugin should also still be compatible with the older versions of Jekyll.

@matze
Copy link
Author

matze commented Sep 28, 2013

Nice! Would be great though to see this merged upstream.

@rwmpelstilzchen
Copy link

Please merge @IQAndreas's solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants