You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been trying to make redis-nds to pass all unit tests today, i found we got a problem with replication and debug reload command, cause they still need to use rdbSave, and rdbSave don't save the dirty keys, which cause losing data when replicating.
Simple fix is to add a call of flushDirtyKeys in rdbSave, like i did in my fix-replication branch, but which lead to another question: what if the background flushing process is running.
I'm not that familiar with lmdb api, i'm not sure is flushDirtyKeys safe to use concurrently in multiple processes. If not, then we have problem each time we call flushDirtyKeys in main process.
The text was updated successfully, but these errors were encountered:
I've been trying to make redis-nds to pass all unit tests today, i found we got a problem with replication and
debug reload
command, cause they still need to userdbSave
, andrdbSave
don't save the dirty keys, which cause losing data when replicating.Simple fix is to add a call of
flushDirtyKeys
inrdbSave
, like i did in myfix-replication
branch, but which lead to another question: what if the background flushing process is running.I'm not that familiar with lmdb api, i'm not sure is
flushDirtyKeys
safe to use concurrently in multiple processes. If not, then we have problem each time we callflushDirtyKeys
in main process.The text was updated successfully, but these errors were encountered: