Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include namespace in bound named parameters? #118

Open
nivekuil opened this issue May 8, 2021 · 1 comment · May be fixed by #125
Open

Include namespace in bound named parameters? #118

nivekuil opened this issue May 8, 2021 · 1 comment · May be fixed by #125

Comments

@nivekuil
Copy link
Contributor

nivekuil commented May 8, 2021

See this patch nivekuil@de53876 without it, :values {:user/id 1} tries to be bound to :id instead of :user/id. Think this change is worth upstreaming?
@mpenet
Copy link
Owner

mpenet commented May 12, 2021 •
edited
Loading

Hi

Yes that would be worth fixing. Feel free to send a pr. This would be a breaking change potentially for some tho.

@nivekuil nivekuil linked a pull request Sep 11, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include namespace in bound keywords nivekuil/alia
2 participants
@mpenet @nivekuil