From 849425b47f02ef8d9ad1b098d1c89aef54dac6cc Mon Sep 17 00:00:00 2001 From: MPrograms <44033294+mprograms@users.noreply.github.com> Date: Thu, 23 Dec 2021 01:56:55 -0500 Subject: [PATCH] v1.1.3 --- changelog.md | 7 +++++++ library.properties | 2 +- readme.md | 2 +- src/SimpleRotary.cpp | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/changelog.md b/changelog.md index 14778ce..feca430 100644 --- a/changelog.md +++ b/changelog.md @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [v1.1.3] +### Fixed +- Removed default parameter value for pushType(). The function pushType() already requires a parameter so the default is redundant. + +### Changed +- readme.md changed pushType() function documentation to make it clearer that a parameter is required. + ## [v1.1.2] ### Fixed - Typo in library.properties. diff --git a/library.properties b/library.properties index 0a33c8c..b1ddf29 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=SimpleRotary -version=1.1.2 +version=1.1.3 author=MPrograms maintainer=MPrograms sentence=Library for using rotary encorders. diff --git a/readme.md b/readme.md index c5ea81d..7ab5c38 100644 --- a/readme.md +++ b/readme.md @@ -167,7 +167,7 @@ This function will return a single byte of three possible values: ``` void loop(){ - byte t = rotary.pushType(); + byte t = rotary.pushType(1000); // Short Push if ( t == 1 ) { // Do something cool. diff --git a/src/SimpleRotary.cpp b/src/SimpleRotary.cpp index 960d508..e8e2a59 100644 --- a/src/SimpleRotary.cpp +++ b/src/SimpleRotary.cpp @@ -261,7 +261,7 @@ byte SimpleRotary::pushLong(int i) { @return byte **/ -byte SimpleRotary::pushType(int i = 1000){ +byte SimpleRotary::pushType(int i){ _updateTime(); _statusS = ( digitalRead(_pinS) == _trigger ) ? true : false; byte val = 0x00;