Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Zoom and pan with touchpad gestures #15787

Open
ratijas opened this issue Feb 2, 2025 · 6 comments
Open

[Feature Request] Zoom and pan with touchpad gestures #15787

ratijas opened this issue Feb 2, 2025 · 6 comments

Comments

@ratijas
Copy link

ratijas commented Feb 2, 2025

Expected behavior of the wanted feature

Let's make it possible to zoom and pan via multitouch (2 fingers) gestures on a touchpad on desktop platforms.

At least on Linux pinch events from libinput can be used, which I believe is what Firefox doing: GESTURE_PINCH_BEGIN, GESTURE_PINCH_UPDATE and GESTURE_PINCH_END. Other major platforms such as OS X and Windows surely provide their own system API as well.

Use case: watching 4K footage on a FullHD monitor, quickly zooming in to see the details.

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

@Akemi
Copy link
Member

Akemi commented Feb 2, 2025

btw, on macOS this already changes the window size (changes the window scale).

@ratijas
Copy link
Author

ratijas commented Feb 4, 2025

I must admit, I haven't used OS X in years, and I'm mainly interested in Linux platform (mostly X11, but aren't they all libinput anyways?)

@Bellavene
Copy link

Bellavene commented Feb 17, 2025

btw, on macOS this already changes the window size (changes the window scale).

Yeah, but that doesn't work well with wm's. Better if it would zoom inside the window as any application do.

@Akemi
Copy link
Member

Akemi commented Feb 17, 2025

Yeah, but that doesn't work well with wm's. Better if it would zoom inside the window as any application do.

no, that's completely subjective. better would be to make it configurable like anything else.

also:

  • the current behaviour on macOS was actually request a few times before
  • not any other application does this, especially not video players
    • iina behaves the same
    • quicktime goes fullscreen

@Bellavene
Copy link

Bellavene commented Feb 17, 2025

better would be to make it configurable like anything else.

That's true

iina behaves the same

iina is mpv undercover, so strange that you mention it.

not any other application does this

Most applications do exactly that, you pinch, you zoom inside. Like on a tablet, phone, etc.
Pinch to resize a window is something i've never seen in any application. Because you zoom inside a document, not the window...

quicktime goes fullscreen

Yeah, because that is more logical than resize the window.

Now to the real subjective part, I hate how mpv tries to manage its window. It is ok for people who are usual user's (who will never install mpv btw, that's what iina is for), but cringe if you use wm's on macos, I have seen complaints about it from linux user's too.

@Akemi
Copy link
Member

Akemi commented Feb 17, 2025

iina is mpv undercover, so strange that you mention it.

no idea what your point is.

Most applications do exactly that, you pinch, you zoom inside. Like on a tablet, phone, etc. Pinch to resize a window is something i've never seen in any application. Because you zoom inside a document, not the window...

"most applications" is not "any application". most applications are not video players. tablet and phones have a different control concept than a desktop OS.

like mentioned before, this is completely irrelevant for the issue/feature request at hand because hardcoding any kind of behaviour (or changing it) will just lead to arguing what would be better. i would appreciate it if you could drop this discussion please, you made your point the first time, there is no need to repeat yourself.

Yeah, because that is more logical than resize the window.

that's not what i said. it's a non-judgemental specific example of other video players and how they behave, that contradict your claim.

the last part is completely off topic and if you have any other unrelated problem, please open a separate discussion or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants