Skip to content

Commit

Permalink
fix: remove isUserFetched dependency from onboarding social
Browse files Browse the repository at this point in the history
  • Loading branch information
chambaz committed Sep 27, 2024
1 parent 5e34414 commit d33d5c5
Showing 1 changed file with 5 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {

export const OnboardingSocial = ({
mrgnState,
userDataFetched,
flow,
isLoading,
isActiveLoading,
Expand All @@ -44,10 +43,7 @@ export const OnboardingSocial = ({
const [successProps, setSuccessProps] = React.useState<SuccessProps>();
const [isSocialAuthLoading, setIsSocialAuthLoading] = React.useState<boolean>(false);

const userHasAcct = React.useMemo(
() => userDataFetched && mrgnState?.selectedAccount,
[mrgnState?.selectedAccount, userDataFetched]
);
const userHasAcct = React.useMemo(() => mrgnState?.selectedAccount, [mrgnState?.selectedAccount]);

const screen = React.useMemo(() => {
if (installingWallet) {
Expand Down Expand Up @@ -75,7 +71,7 @@ export const OnboardingSocial = ({
}, [screenIndex]);

React.useEffect(() => {
if (connected && userDataFetched && screenIndex === 0) {
if (connected && screenIndex === 0) {
setIsActiveLoading("");
setIsLoading(false);
setIsSocialAuthLoading(false);
Expand All @@ -85,10 +81,10 @@ export const OnboardingSocial = ({
if (userHasAcct) {
setScreenIndex((prev) => prev++);
}
} else if (connected && !userDataFetched && screenIndex === 0) {
} else if (connected && screenIndex === 0) {
setIsSocialAuthLoading(true);
}
}, [userDataFetched, userHasAcct, connected, screenIndex]);
}, [userHasAcct, connected, screenIndex]);

const onSelectWallet = React.useCallback(
(selectedWallet: ExtendedWallet) => {
Expand Down Expand Up @@ -137,7 +133,7 @@ export const OnboardingSocial = ({
/>

{isSocialAuthLoading ? (
<Loader />
<Loader label="Loading..." />
) : (
React.createElement(screen.comp, {
isLoading: isLoading,
Expand Down

0 comments on commit d33d5c5

Please sign in to comment.