Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Is this repo still maintained? #77

Closed
p3k opened this issue Feb 27, 2019 · 7 comments
Closed

Is this repo still maintained? #77

p3k opened this issue Feb 27, 2019 · 7 comments

Comments

@p3k
Copy link
Contributor

p3k commented Feb 27, 2019

No description provided.

@msokk
Copy link
Owner

msokk commented Feb 27, 2019

@p3k Hi, I don't use it personally anymore, but API is stable, just haven't had time bump electron version for some time. In the latest version, things are rendered by Chrome 58.

Probably should link to something like https://github.com/esbenp/pdf-bot

@p3k
Copy link
Contributor Author

p3k commented Feb 27, 2019

thanks for the quick reply @msokk. true, the api is stable, that’s why we like using it! 🐱

however, electron version is in fact pretty outdated. we have an issue with a css box-border definition not being displayed; thus, i guess we will fork from here and bump the version number.

thanks for the good work and keep on diggin’!

@msokk
Copy link
Owner

msokk commented Feb 27, 2019

ah ok, I'll see what I can do for v2 release :)

I bumped all dependencies to latest and kicked off Travis build, but looks like Electron v4 is not happy with Debian Jessie libdbus.

@p3k
Copy link
Contributor Author

p3k commented Feb 27, 2019

yes, i’ve seen that error, too, when using a manually built service with electron 4.0.6… however, it did not seem to affect the rendering, at least i got my pdf as expected. (certainly, it could be i am just not using a feature libdbus is needed for.)

@msokk
Copy link
Owner

msokk commented Feb 28, 2019

Yeah, it was not the real cause, they changed some methods like, toPng to toPNG so it crashed.
Looks like some letters have minute font rendering changes.
I have almost all tests passing, for some reason 2 tests render blank PDF only on Travis CI.

@cyril23
Copy link

cyril23 commented Mar 21, 2019

I have updated Electron to 4.0.5: #85

@msokk
Copy link
Owner

msokk commented Apr 27, 2019

Added maintenance notice.
https://github.com/alvarcarto/url-to-pdf-api - looks like a quite similar active project built upon headless Chrome

@msokk msokk closed this as completed Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants