From 65286e60284f0fa05e8d1916426f180ab6a60b60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miquel=20Sabat=C3=A9=20Sol=C3=A0?= Date: Fri, 10 May 2024 07:52:36 +0200 Subject: [PATCH] ci: git-validation can go suck an egg MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miquel Sabaté Solà --- .github/workflows/ci.yml | 5 ----- CONTRIBUTING.org | 19 ------------------- Makefile | 10 +--------- 3 files changed, 1 insertion(+), 33 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7488ce0..f47d2d7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,12 +40,7 @@ jobs: with: version: ${{ matrix.emacs_version }} - - uses: actions/setup-go@v5 - - uses: actions/checkout@v4 - - name: Install git-validation - run: go install github.com/vbatts/git-validation@latest - - name: make ci run: make ci diff --git a/CONTRIBUTING.org b/CONTRIBUTING.org index ab276e6..34d5f96 100644 --- a/CONTRIBUTING.org +++ b/CONTRIBUTING.org @@ -31,25 +31,6 @@ style. You can run these checkers by performing: $ make lint #+END_SRC -*** Git validation - -In order to ensure that the git log is as maintainable as possible, the -[[https://github.com/vbatts/git-validation][git-validation]] tool is used. You can install this tool by running: - -#+BEGIN_SRC bash -$ go get -u github.com/vbatts/git-validation -#+END_SRC - -If you already have this tool installed, then simply perform: - -#+BEGIN_SRC bash -$ make git-validation -#+END_SRC - -Note that if you don't have this tool installed the task will do nothing (it -will just print a help message). This is done so when running the default make -task this doesn't interrupt it. - *** Load test In order to test that this theme can be actually loaded, run: diff --git a/Makefile b/Makefile index 5e27e1d..724c9c2 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ $(OBJECTS): %.elc: %.el ci: version all .PHONY: test -test: lint git-validation checkdoc load-test +test: lint checkdoc load-test # Maybe it would've been nicer to use Cask or something like that, but it # doesn't have too many dependencies so it should be fine for now. @@ -70,14 +70,6 @@ fix-stdlib-changes: lint: vendor fix-stdlib-changes @$(BATCH) -l elisp-lint.el -f elisp-lint-files-batch $(ELS) -.PHONY: git-validation -git-validation: -ifeq (, $(shell which git-validation 2> /dev/null)) - @echo "You don't have 'git-validation' installed, consider installing it (see the CONTRIBUTING.org file)." -else - @git-validation -q -range 7d38ca68163c..HEAD -travis-pr-only=false -endif - .PHONY: load-test load-test: @$(BATCH) -nw --load soria-theme.el \