Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #20

Closed
msteinert opened this issue Nov 30, 2023 · 4 comments
Closed

Version 2 #20

msteinert opened this issue Nov 30, 2023 · 4 comments

Comments

@msteinert
Copy link
Owner

Apparently v2 tags are not supported.

https://go.dev/blog/v2-go-modules

This issue is a reminder to follow up on a v2 release as described in the link.

@3v1n0
Copy link
Collaborator

3v1n0 commented Nov 30, 2023

Wow... That's weird, so should we move to a v2 folder or do you instead want to do a non-as-major release instead?

@msteinert
Copy link
Owner Author

Hmm, I'm not sure. I need to reread that series of blog posts and think about it a bit. Maintaining two versions feels like a lot of work for this particular project. At the same time I would feel bad breaking the API. I might try to take a look at how other projects are handling this too.

Let me know what you think.

@msteinert
Copy link
Owner Author

msteinert commented Nov 30, 2023

I think this might be the model to follow: https://github.com/jackc/pgx

If I understand correctly, the module name is updated in go.mod, then the older version is maintained on a branch.

@msteinert
Copy link
Owner Author

Fixed by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants