Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐ Create custom AST instead of current to_python/core/types.py #47

Open
Toliak opened this issue Sep 1, 2021 · 0 comments
Open

⭐ Create custom AST instead of current to_python/core/types.py #47

Toliak opened this issue Sep 1, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Toliak
Copy link
Member

Toliak commented Sep 1, 2021 •
edited
Loading

Why

  • Current structure requires a lot of work to edit something.
  • TypeScriptFunctionGenerator generates TypeScript for the entire FunctionData (cannot usr only for argument list, for example)

Comparison

Advantages

  • More flexible
  • Can walk to parent and to children

Disadvantages

  • Parser (from tokenized to python) should be rewritten
  • Printer (to_typescript) should be rewritten too
@Toliak Toliak added the enhancement New feature or request label Sep 1, 2021
Toliak added a commit that referenced this issue Sep 1, 2021
@Toliak
Provide Node types for AST (#47)
fbb9594
@Toliak Toliak added the help wanted Extra attention is needed label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Toliak