From 50c64b851239a194d59c9b784e12ec2f0f598fe5 Mon Sep 17 00:00:00 2001
From: Mark Thom <mark.thom@unb.ca>
Date: Sat, 11 Nov 2023 18:41:46 +0100
Subject: [PATCH] correct style failures

---
 src/debray_allocator.rs | 43 +++++++++++++++++++----------------------
 src/forms.rs            | 15 ++------------
 src/machine/loader.rs   | 10 ++--------
 src/parser/ast.rs       | 10 ++--------
 4 files changed, 26 insertions(+), 52 deletions(-)

diff --git a/src/debray_allocator.rs b/src/debray_allocator.rs
index 89ef44f3d..30bb0a24b 100644
--- a/src/debray_allocator.rs
+++ b/src/debray_allocator.rs
@@ -166,32 +166,29 @@ impl DebrayAllocator {
         for var_num in subsumed_hits {
             match &mut self.var_data.records[var_num].allocation {
                 VarAlloc::Perm(_, ref mut allocation) => {
-                    match allocation {
-                        PermVarAllocation::Done {
-                            shallow_safety,
-                            deep_safety,
-                            ..
-                        } => {
-                            if !self
-                                .branch_stack
-                                .safety_unneeded_in_branch(shallow_safety, &branch_designator)
-                            {
-                                let branch_occurrences = self.branch_stack.last_mut().unwrap();
-                                branch_occurrences.shallow_safety.insert(var_num);
-                            }
-
-                            if !self
-                                .branch_stack
-                                .safety_unneeded_in_branch(deep_safety, &branch_designator)
-                            {
-                                let branch_occurrences = self.branch_stack.last_mut().unwrap();
-                                branch_occurrences.deep_safety.insert(var_num);
-                            }
+		    if let PermVarAllocation::Done {
+                        shallow_safety,
+                        deep_safety,
+                        ..
+                    } = allocation
+		    {
+                        if !self
+                            .branch_stack
+                            .safety_unneeded_in_branch(shallow_safety, &branch_designator)
+                        {
+                            let branch_occurrences = self.branch_stack.last_mut().unwrap();
+                            branch_occurrences.shallow_safety.insert(var_num);
                         }
-                        _ => {
+
+                        if !self
+                            .branch_stack
+                            .safety_unneeded_in_branch(deep_safety, &branch_designator)
+                        {
+                            let branch_occurrences = self.branch_stack.last_mut().unwrap();
+                            branch_occurrences.deep_safety.insert(var_num);
                         }
                     }
-
+		    
                     *allocation = PermVarAllocation::Pending;
                 }
                 _ => unreachable!(),
diff --git a/src/forms.rs b/src/forms.rs
index 50a24b23c..d905571fc 100644
--- a/src/forms.rs
+++ b/src/forms.rs
@@ -876,7 +876,7 @@ impl ClauseIndexInfo {
     }
 }
 
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Copy, Debug, Default)]
 pub(crate) struct PredicateInfo {
     pub(crate) is_extensible: bool,
     pub(crate) is_discontiguous: bool,
@@ -885,18 +885,7 @@ pub(crate) struct PredicateInfo {
     pub(crate) has_clauses: bool,
 }
 
-impl Default for PredicateInfo {
-    #[inline]
-    fn default() -> Self {
-        PredicateInfo {
-            is_extensible: false,
-            is_discontiguous: false,
-            is_dynamic: false,
-            is_multifile: false,
-            has_clauses: false,
-        }
-    }
-}
+
 
 impl PredicateInfo {
     #[inline]
diff --git a/src/machine/loader.rs b/src/machine/loader.rs
index c795c973f..fb200f03b 100644
--- a/src/machine/loader.rs
+++ b/src/machine/loader.rs
@@ -148,9 +148,10 @@ impl<'a, LS: LoadState<'a>> Drop for Loader<'a, LS> {
     }
 }
 
-#[derive(Debug, Clone, Copy, Hash, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, Hash, PartialEq, Eq, Default)]
 pub enum CompilationTarget {
     Module(Atom),
+    #[default]
     User,
 }
 
@@ -163,13 +164,6 @@ impl fmt::Display for CompilationTarget {
     }
 }
 
-impl Default for CompilationTarget {
-    #[inline]
-    fn default() -> Self {
-        CompilationTarget::User
-    }
-}
-
 impl CompilationTarget {
     #[inline]
     pub(crate) fn module_name(&self) -> Atom {
diff --git a/src/parser/ast.rs b/src/parser/ast.rs
index 4859a65e9..ec46a74fc 100644
--- a/src/parser/ast.rs
+++ b/src/parser/ast.rs
@@ -327,8 +327,9 @@ impl DoubleQuotes {
     }
 }
 
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Default)]
 pub enum Unknown {
+    #[default]
     Error,
     Fail,
     Warn,
@@ -348,13 +349,6 @@ impl Unknown {
     }
 }
 
-impl Default for Unknown {
-    #[inline]
-    fn default() -> Self {
-        Unknown::Error
-    }
-}
-
 pub fn default_op_dir() -> OpDir {
     let mut op_dir = OpDir::with_hasher(FxBuildHasher::default());