Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong initialization of transformer mixer hyperparameters #5

Open
wzz618 opened this issue Jan 8, 2025 · 0 comments
Open

Wrong initialization of transformer mixer hyperparameters #5

wzz618 opened this issue Jan 8, 2025 · 0 comments

Comments

@wzz618
Copy link

wzz618 commented Jan 8, 2025

In your papar, transformer mixer has only 3 hyperparameters, but when initializing you initialize the hyperparameters by the number of n_agents:
Your codes:

# src/modules/mixers/n_transf_mixer.py (code: 52-53)
def init_hidden(self):
    return th.zeros(1, self.n_agents, self.args.emb).to(self.args.device)

Need to be

def init_hidden(self):
    return th.zeros(1, 3, self.args.emb).to(self.args.device)

And same in

# src/learners/nq_transf_learner.py (code: 112)
# src/learners/nq_transf_learner.py (code: 137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant