From 32bfe20df112245c0569b403fc6d57ba2d4c91d7 Mon Sep 17 00:00:00 2001 From: ZeeshanTamboli Date: Thu, 8 Jan 2026 15:51:16 +0530 Subject: [PATCH 1/4] add failing test --- .../mui-material/src/Drawer/Drawer.test.js | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/packages/mui-material/src/Drawer/Drawer.test.js b/packages/mui-material/src/Drawer/Drawer.test.js index b67d771cd081bc..e0a1ec4c9ad700 100644 --- a/packages/mui-material/src/Drawer/Drawer.test.js +++ b/packages/mui-material/src/Drawer/Drawer.test.js @@ -281,6 +281,33 @@ describe('', () => { expect(handleEntered.callCount).to.equal(1); expect(container.firstChild.firstChild).to.have.class(classes.paper); }); + + it.skipIf(isJsdom())('should not apply modal styles from theme styleOverrides', () => { + const theme = createTheme({ + components: { + MuiDrawer: { + styleOverrides: { + modal: { + backgroundColor: '#32a852', + }, + }, + }, + }, + }); + + const { container } = render( + + +
+ + , + ); + + const root = container.querySelector(`.${classes.root}`); + expect(root).not.toHaveComputedStyle({ + backgroundColor: '#32a852', + }); + }); }); describe('prop: variant=permanent', () => { From 50255a49a120d465e72d545d7ce7a593da9f4081 Mon Sep 17 00:00:00 2001 From: ZeeshanTamboli Date: Thu, 8 Jan 2026 16:04:56 +0530 Subject: [PATCH 2/4] change color --- packages/mui-material/src/Drawer/Drawer.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/mui-material/src/Drawer/Drawer.test.js b/packages/mui-material/src/Drawer/Drawer.test.js index e0a1ec4c9ad700..11bcd9b3acd26b 100644 --- a/packages/mui-material/src/Drawer/Drawer.test.js +++ b/packages/mui-material/src/Drawer/Drawer.test.js @@ -288,7 +288,7 @@ describe('', () => { MuiDrawer: { styleOverrides: { modal: { - backgroundColor: '#32a852', + backgroundColor: 'rgb(0, 0, 255)', }, }, }, @@ -305,7 +305,7 @@ describe('', () => { const root = container.querySelector(`.${classes.root}`); expect(root).not.toHaveComputedStyle({ - backgroundColor: '#32a852', + backgroundColor: 'rgb(0, 0, 255)', }); }); }); From 1390f2daf517153fc68605049bfefb109bf81939 Mon Sep 17 00:00:00 2001 From: ZeeshanTamboli Date: Thu, 8 Jan 2026 18:54:20 +0530 Subject: [PATCH 3/4] add for permanent variant as well, loop tests --- .../mui-material/src/Drawer/Drawer.test.js | 59 ++++++++++--------- 1 file changed, 32 insertions(+), 27 deletions(-) diff --git a/packages/mui-material/src/Drawer/Drawer.test.js b/packages/mui-material/src/Drawer/Drawer.test.js index 11bcd9b3acd26b..e5bd91f3188f39 100644 --- a/packages/mui-material/src/Drawer/Drawer.test.js +++ b/packages/mui-material/src/Drawer/Drawer.test.js @@ -281,33 +281,6 @@ describe('', () => { expect(handleEntered.callCount).to.equal(1); expect(container.firstChild.firstChild).to.have.class(classes.paper); }); - - it.skipIf(isJsdom())('should not apply modal styles from theme styleOverrides', () => { - const theme = createTheme({ - components: { - MuiDrawer: { - styleOverrides: { - modal: { - backgroundColor: 'rgb(0, 0, 255)', - }, - }, - }, - }, - }); - - const { container } = render( - - -
- - , - ); - - const root = container.querySelector(`.${classes.root}`); - expect(root).not.toHaveComputedStyle({ - backgroundColor: 'rgb(0, 0, 255)', - }); - }); }); describe('prop: variant=permanent', () => { @@ -477,4 +450,36 @@ describe('', () => { expect(document.querySelector(`.${classes.root}`)).to.have.class(classes.anchorBottom); }); }); + + ['permanent', 'persistent'].forEach((variant) => { + it.skipIf(isJsdom())( + `should not apply modal styles from theme styleOverrides for variant=${variant}`, + () => { + const theme = createTheme({ + components: { + MuiDrawer: { + styleOverrides: { + modal: { + backgroundColor: 'rgb(0, 0, 255)', + }, + }, + }, + }, + }); + + const { container } = render( + + +
+ + , + ); + + const root = container.querySelector(`.${classes.root}`); + expect(root).not.toHaveComputedStyle({ + backgroundColor: 'rgb(0, 0, 255)', + }); + }, + ); + }); }); From 689d187ca31b8779d51ac1d6dc073305ba528be9 Mon Sep 17 00:00:00 2001 From: ZeeshanTamboli Date: Thu, 8 Jan 2026 18:58:41 +0530 Subject: [PATCH 4/4] add fix --- packages/mui-material/src/Drawer/Drawer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mui-material/src/Drawer/Drawer.js b/packages/mui-material/src/Drawer/Drawer.js index b7c1aca48129a4..f1c1d0366c48d6 100644 --- a/packages/mui-material/src/Drawer/Drawer.js +++ b/packages/mui-material/src/Drawer/Drawer.js @@ -23,7 +23,7 @@ const overridesResolver = (props, styles) => { return [ styles.root, (ownerState.variant === 'permanent' || ownerState.variant === 'persistent') && styles.docked, - styles.modal, + ownerState.variant === 'temporary' && styles.modal, ]; };