Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postman collection issues #173

Open
DavoCoder opened this issue Jan 10, 2022 · 0 comments
Open

Postman collection issues #173

DavoCoder opened this issue Jan 10, 2022 · 0 comments

Comments

@DavoCoder
Copy link
Collaborator

DavoCoder commented Jan 10, 2022

When trying to execute the postman collection for the first time, the following error appears on the pre-request scripts: "TypeError: Cannot read property 'toLowerCase' of undefined", removing "toLowerCase()" from the code solves the problem.
Aside from this error, having to set global variables and 1 environment variables (url) + understanding that the headers are inherited and managed by pre-request scripts seems to be a setup overhead for a standard user.
Some suggestions to simplify this:

  • Use environment variables for everything (avoid using globals); there are environments and usages of the metrics toolkit where multiple users / connected apps are needed per environment / account / BG
  • Each request should be atomic. It should explicitly contain all the Headers needed - this is for developers' visibility (externalize values using environment variables)
  • Provide an example environment file with the "keys" already filled, so that users can quickly import and modify the values instead of having to type each variable from scratch
  • The Pre-request scripts should point to environment variables instead of global ones
  • Postman collections documentation is a great feature from Postman, however, it is not known by everyone, I would mention in the README of the project (this GitHub repo) that the postman collection is documented in Postman itself (sounds redundant but it will help some users)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant