Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cbindgen to the android build container #6811

Merged

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Sep 18, 2024

This PR aims to add cbindgen as part of the Android build container. This is an improvement to how it was added in multiple build scripts and workflows in #6684 as well as #6808 and #6757 (which will be partially reverted after the new container image has been published). We also aim to improve this further as part of our internal issue: DROID-1328.


This change is Reviewable

Copy link

linear bot commented Sep 18, 2024

@albin-mullvad albin-mullvad self-assigned this Sep 18, 2024
@albin-mullvad albin-mullvad added the Android Issues related to Android label Sep 18, 2024
Pururun
Pururun previously approved these changes Sep 18, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Rawa
Rawa previously approved these changes Sep 18, 2024
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the add-cbindgen-to-the-android-build-container-droid-1330 branch from 76b6103 to 52b1aed Compare September 18, 2024 11:47
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/docker/Dockerfile line 119 at r1 (raw file):

# This is an intermediate solution that will be further improved as part of
# issue: DROID-1328.
RUN cargo install --force cbindgen --version "0.26.0"

Would be cool if we could clean the global cargo cache after installing cbindgen 😊

Code quote:

RUN cargo install --force cbindgen --version "0.26.0"

Copy link
Collaborator Author

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @MarkusPettersson98, @Pururun, and @Rawa)


android/docker/Dockerfile line 119 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Would be cool if we could clean the global cargo cache after installing cbindgen 😊

Done!

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/docker/Dockerfile line 119 at r1 (raw file):

Previously, albin-mullvad wrote…

Done!

🎉

@albin-mullvad albin-mullvad force-pushed the add-cbindgen-to-the-android-build-container-droid-1330 branch from 53b14c6 to 424e674 Compare September 18, 2024 15:00
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the add-cbindgen-to-the-android-build-container-droid-1330 branch from 424e674 to e966554 Compare September 18, 2024 15:14
@albin-mullvad albin-mullvad merged commit b5fdd26 into main Sep 18, 2024
22 checks passed
@albin-mullvad albin-mullvad deleted the add-cbindgen-to-the-android-build-container-droid-1330 branch September 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants