From fdb0e426978eca96d4b7276f3a73bbca2ad180ae Mon Sep 17 00:00:00 2001
From: Tudor Morar <tudor.morar@multiversx.com>
Date: Thu, 19 Sep 2024 14:57:18 +0300
Subject: [PATCH] Change ledger guardian signing to cross window

---
 .../sdk-dapp/internal-processes/guardians.md  | 31 +++++++++++++------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/docs/sdk-and-tools/sdk-dapp/internal-processes/guardians.md b/docs/sdk-and-tools/sdk-dapp/internal-processes/guardians.md
index 4171f4c4..79960260 100644
--- a/docs/sdk-and-tools/sdk-dapp/internal-processes/guardians.md
+++ b/docs/sdk-and-tools/sdk-dapp/internal-processes/guardians.md
@@ -44,16 +44,27 @@ All signing providers (except Ledger) take care internally of formatting the tra
 After formatting the transaction and applying the signature provided by the Ledger device, the transaction must be signed by the Guardian. This is done by sending the transaction (or transactions array) to the web wallet 2FA hook. The web wallet will then prompt the user to sign the transaction with the Guardian account, and respond with the signed transaction.
 
 ```js
-import { WalletProvider } from '@multiversx/sdk-web-wallet-provider';
-
-const walletProvider = new WalletProvider('https://wallet.multiversx.com/dapp/init');
-walletProvider.guardTransactions(transactions, {
-    callbackUrl: encodeURIComponent('https://my-dapp.com'),
-});
+import { CrossWindowProvider } from "@multiversx/sdk-web-wallet-cross-window-provider";
+
+// instantiate wallet cross-window provider
+await CrossWindowProvider.getInstance().init();
+const crossWindowProvider = CrossWindowProvider.getInstance();
+crossWindowProvider.setWalletUrl(WALLET_PROVIDER_URL);
+
+// set sender
+const ledgerSenderBech32 = await this.hwProvider.getAddress();
+const ledgerSender = new Address(senderBech32);
+const sender = ledgerSender; // or "erd1...abc" witohut awaiting `getAddress()`
+crossWindowProvider.setAddress(sender);
+
+// the user signs transactions on ledger so we need to perform an extra
+// user action with a confirmation popup so the browser opens the new tab
+crossWindowProvider.setShouldShowConsentPopup(true);
+
+const guardedTransactions = await crossWindowProvider.guardTransactions(
+    signedTransactions
+);
 ```
-Once transactions are back from the web wallet, they can be retrieved as follows:
 
-```js
-const signedTransactions = new WalletProvider('https://wallet.multiversx.com/dapp/init').getTransactionsFromWalletUrl();
-```
+For a working example see the code used in [signing-providers](https://github.com/multiversx/mx-sdk-js-examples/blob/594465208fd3a9d5c57bca8ecc94f2dc59cbf4a6/signing-providers/src/hw.js#L87)