Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect merge of debuglog pull request from 2012? #88

Open
Lerrissirrel opened this issue Dec 15, 2021 · 0 comments
Open

Incorrect merge of debuglog pull request from 2012? #88

Lerrissirrel opened this issue Dec 15, 2021 · 0 comments

Comments

@Lerrissirrel
Copy link

I feel like I must be missing something here. After researching why I've been getting spurts of "Event ID 1" every few minutes from munin-node, I ran across the issue #4. So I set the appropriate setting in munin-node.ini and it was still happening. Figured I needed to start debugging the code, and along the way I realized that there are two places that call EventLog.Write in src/core/Services.cpp and I think the original pull request meant to modify CService::LogEvent() while the change actually landed in CService::LogError().

This leaves the (unconditional) LogEvents() from src/plugins/PerfCounterMuninNodePlugin.cpp continuing to log. Now, it does appear that these non-conditional LogEvent() calls got added with commit
098b0a5 which came in Feb 2020, long after the original "fix" from issue #4.

Long story short, I don't know the intent of the original ini setting - disable Events only? Errors only? Both? Nor do I know the intent of the LogEvent()s in the plugin or what is considered the "correct" approach to errors/events in munin-node-win32. So just alerting here for those more in the know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant