Skip to content

Remove deprecated ioutil call #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strider2038 merged 2 commits into from
Feb 16, 2025
Merged

Remove deprecated ioutil call #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1047b5c
remove deprecated ioutil call
kukymbr Apr 12, 2024
3d6b1bc
bump go version up to 1.16
kukymbr Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assertjson/assertjson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package assertjson
import (
"encoding/json"
"fmt"
"io/ioutil"
"os"
"strconv"
"strings"

Expand Down Expand Up @@ -39,7 +39,7 @@ type JSONAssertFunc func(json *AssertJSON)
// FileHas loads JSON from file and runs user callback for testing its nodes.
func FileHas(t TestingT, filename string, jsonAssert JSONAssertFunc) {
t.Helper()
data, err := ioutil.ReadFile(filename)
data, err := os.ReadFile(filename)
Copy link
Contributor

@strider2038 strider2038 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go version need to be upgraded to at least v1.16 in go.mod file

Copy link
Contributor Author

@kukymbr kukymbr Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u plan to support older versions of go in next releases?

Copy link
Contributor

@strider2038 strider2038 Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor Author

@kukymbr kukymbr Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 1.16

if err != nil {
assert.Fail(t, fmt.Sprintf(`failed to read file "%s": %s`, filename, err.Error()))
} else {
Expand Down
4 changes: 2 additions & 2 deletions assertxml/assertxml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ package assertxml
import (
"bytes"
"fmt"
"io/ioutil"
"os"

"github.com/stretchr/testify/assert"
"gopkg.in/xmlpath.v2"
Expand All @@ -56,7 +56,7 @@ type XMLAssertFunc func(xml *AssertXML)
// FileHas loads XML from file and runs user callback for testing its nodes.
func FileHas(t TestingT, filename string, xmlAssert XMLAssertFunc) {
t.Helper()
data, err := ioutil.ReadFile(filename)
data, err := os.ReadFile(filename)
if err != nil {
assert.Failf(t, "failed to read file '%s': %s", filename, err.Error())
} else {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/muonsoft/api-testing

go 1.13
go 1.16

require (
github.com/gofrs/uuid v4.4.0+incompatible
Expand Down
Loading