Fix memory leak

Author: RomanPudashkin

src/framework/cloud/internal/abstractcloudservice.cpp

@@ -406,30 +406,38 @@ Ret AbstractCloudService::executeRequest(const RequestCallback& requestCallback)
 
 Promise<Ret> AbstractCloudService::executeAsyncRequest(const AsyncRequestCallback& requestCallback)
 {
-    return requestCallback().then<Ret>(this, [this, requestCallback](const Ret& ret, auto resolve) {
+    //! NOTE: helps to avoid memory leak due to self-capture
+    auto callback = new AsyncRequestCallback(requestCallback);
+
+    return requestCallback().then<Ret>(this, [this, callback](const Ret& ret, auto resolve) {
         if (ret) {
+            delete callback;
             return resolve(ret);
         }
 
         // Check whether tokens have expired...
         if (statusCode(ret) != USER_UNAUTHORIZED_STATUS_CODE) {
+            delete callback;
             return resolve(ret);
         }
 
         // Update tokens and retry request
-        updateTokens().onResolve(this, [this, requestCallback, resolve](const Ret& ret) {
+        updateTokens().onResolve(this, [this, callback, resolve](const Ret& ret) {
             if (!ret) {
+                delete callback;
                 (void)resolve(ret);
                 return;
             }
 
             Ret saveTokensRet = saveTokens();
             if (!saveTokensRet) {
+                delete callback;
                 (void)resolve(saveTokensRet);
                 return;
             }
 
-            requestCallback().onResolve(this, [resolve](const Ret& ret) {
+            (*callback)().onResolve(this, [resolve, callback](const Ret& ret) {
+                delete callback;
                 (void)resolve(ret);
             });
         });

src/project/internal/projectactionscontroller.cpp

@@ -900,8 +900,7 @@ void ProjectActionsController::uploadAudioToAudioCom(const AudioFile& audio, con
 
     m_uploadingAudioProgress->finished().onReceive(this, [this, audio, project, info](const ProgressResult& res) {
         LOGD() << "Uploading audio finished";
-
-        audio.device->deleteLater();
+        (void)audio; // make sure it lives long enough
 
         if (!res.ret) {
             LOGE() << res.ret.toString();
@@ -915,6 +914,10 @@ void ProjectActionsController::uploadAudioToAudioCom(const AudioFile& audio, con
                 project->setCloudAudioInfo(newInfo);
             }
         }
+
+        m_uploadingAudioProgress->started().disconnect(this);
+        m_uploadingAudioProgress->progressChanged().disconnect(this);
+        m_uploadingAudioProgress->finished().disconnect(this);
     });
 }
 
@@ -1281,6 +1284,8 @@ Ret ProjectActionsController::uploadProject(const CloudProjectInfo& info, const
     m_uploadingProjectProgress->finished().onReceive(this, [this, project, info, audio, openEditUrl, publishMode,
                                                             isFirstSave, &ret, &eventLoop](const ProgressResult& res) {
         DEFER {
+            m_uploadingProjectProgress->progressChanged().disconnect(this);
+            m_uploadingProjectProgress->finished().disconnect(this);
             eventLoop.quit();
         };
 
@@ -1355,6 +1360,9 @@ void ProjectActionsController::uploadAudioToMuseScoreCom(const AudioFile& audio,
         if (publishMode && (configuration()->alsoShareAudioCom() || configuration()->showAlsoShareAudioComDialog())) {
             alsoShareAudioCom(audio);
         }
+
+        m_uploadingAudioProgress->progressChanged().disconnect(this);
+        m_uploadingAudioProgress->finished().disconnect(this);
     });
 }