Skip to content

Commit 9ba0bcb

Browse files
manoloigorkorsukov
authored andcommitted
Address review feedback for spanners API
- Use Spanner type instead of EngravingItem for proper type exposure - Replace member variable cache with static local variable - Update comment format to APIDOC style
1 parent b7316d7 commit 9ba0bcb

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/engraving/tests/spanners_tests.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,7 @@ TEST_F(Engraving_SpannersTests, spanners17_pluginAPI_scoreSpanners)
613613
apiv1::Score apiScore(score);
614614

615615
// Get spanners using Plugin API
616-
QQmlListProperty<apiv1::EngravingItem> scoreSpanners = apiScore.spanners();
616+
QQmlListProperty<apiv1::Spanner> scoreSpanners = apiScore.spanners();
617617

618618
// Basic sanity checks: the property should return a valid list
619619
EXPECT_NE(scoreSpanners.count, nullptr);
@@ -632,16 +632,12 @@ TEST_F(Engraving_SpannersTests, spanners17_pluginAPI_scoreSpanners)
632632
// Verify each spanner can be accessed and has valid properties
633633
for (int i = 0; i < spannerCount; i++) {
634634
auto* item = scoreSpanners.at(&scoreSpanners, i);
635-
apiv1::EngravingItem* apiItem = qobject_cast<apiv1::EngravingItem*>(item);
636-
EXPECT_TRUE(apiItem != nullptr) << "Spanner " << i << " should be a valid EngravingItem";
637-
638-
if (apiItem && apiItem->element()) {
639-
// Verify it's actually a spanner
640-
mu::engraving::EngravingItem* elem = apiItem->element();
641-
EXPECT_TRUE(elem->isSpanner()) << "Item " << i << " should be a Spanner";
635+
apiv1::Spanner* apiItem = qobject_cast<apiv1::Spanner*>(item);
636+
EXPECT_TRUE(apiItem != nullptr) << "Spanner " << i << " should be a valid Spanner";
642637

638+
if (apiItem && apiItem->spanner()) {
643639
// Verify we can access the track property (spanners have tracks)
644-
track_idx_t track = elem->track();
640+
track_idx_t track = apiItem->spanner()->track();
645641
EXPECT_GE(track, 0) << "Spanner " << i << " should have a valid track";
646642
}
647643
}

0 commit comments

Comments
 (0)