Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More extensible for loading decoder #30

Open
nikotung opened this issue Feb 17, 2023 · 0 comments · May be fixed by #36
Open

More extensible for loading decoder #30

nikotung opened this issue Feb 17, 2023 · 0 comments · May be fixed by #36
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nikotung
Copy link

nikotung commented Feb 17, 2023

Is your feature request related to a problem? Please describe..
I had come across a same as issue #29 while trying to parse some QRCodes from Phillipines based on the EMVco standard. From the issue #29, I think the example was from Sri Lanka Rupee because the country code is 144.Maybe there are some country implementing the QRcode payment system based on the EMVco specification with a slight difference.

Describe the solution you'd like to see.
By default,all decoders follow the EMVco specification.Also,provide a flexible,extensible way to load another decoder for the same identifier.For example,provide a way to replace the AdditionalDataFieldDecoder,under the ID=62,with a custom decoder in the DecodersMpmMap class.This decoder should be able to decode the QRcode from Phillipines.

@mvallim mvallim self-assigned this Mar 3, 2023
@mvallim mvallim added enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2023
@mvallim mvallim linked a pull request Mar 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants