Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close dbus connection? #43

Open
swistaczek opened this issue Apr 30, 2013 · 2 comments
Open

Close dbus connection? #43

swistaczek opened this issue Apr 30, 2013 · 2 comments

Comments

@swistaczek
Copy link

Hello @mvidner,
I would like to ask you if there is any option to close DBus connection? I am iterating through Modem Manager modems and after gathering some information I would like to close dbus connection.

@mvidner
Copy link
Owner

mvidner commented May 2, 2013

The library currently does not care about closing the connection. That is bad form but I wonder whether it actually hurts in practice. You can get at the socket used by the connection and close it yourself, but please be aware that I consider the socket attribute an implementation detail that may be moved somewhere else.

@mvidner
Copy link
Owner

mvidner commented May 2, 2013

Notes to self: Things to consider when adding DBus::Connection#close:

  • what about non-empty @buffer, do we care?
  • what about the singleton instances DBus.system_bus, DBus.session_bus? Should we allow reopening? Or replacing with a new object?

DBus::ConnectionQueue#close exists in the multithreading branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants