Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements to YAML generation in generate-workflow.py #9

Open
mattmccutchen-cci opened this issue Mar 15, 2021 · 0 comments

Comments

@mattmccutchen-cci
Copy link
Collaborator

mattmccutchen-cci commented Mar 15, 2021

Some ideas to make the YAML generation in generate-workflow.py better after #7:

  • From John: "The python script could include a call to yamllint to sanity check the generated workflow. Easy enough to run manually, but it might catch trivial errors in future changes." This would require everyone who runs generate-workflow.py to install yamllint, so we'd have to think about whether it's worth it.
  • We could generate the output using a YAML library rather than a bunch of manual string manipulation. (Or maybe there is even a library specifically for generating GitHub workflow files?) If there are hard-coded chunks of the workflow file that are easier to understand in YAML format than as hard-coded calls to the YAML library to build the corresponding data structures, we can probably just have the YAML library parse hard-coded YAML strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant