You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strictly speaking you are correct that the bytestring const is better named as an ALPN_ID, but I am not sure if this is really confusing for anybody. In any case, if we change it we will change it at the same time in all our protocol repos.
At least me I was confused this morning and went all the way to the RFC to find out what these ALPNs are.
The confusion is one thing. The other thing is that I have a hard time building up trust in a project when the authors seem to be sloppy with details.
I understand that you still have backwards incompatible changes in your roadmap thus I thought you might consider changing this too before a stable release.
https://github.com/n0-computer/iroh-blobs/blob/main/src/protocol.rs#L353
const ALPN
should be renamed for example toALPN_ID
orPROTOCOL_ID
.ALPN is the negotiation, the process of agreeing on a protocol, not the protocol.
I think it is important to get names right and wrong naming is a usability issue. Wrong names hinder learning and communication.
See also n0-computer/iroh.computer#286
The text was updated successfully, but these errors were encountered: