Skip to content

Commit 730f717

Browse files
flubArqu
andauthored
tests(iroh): Mark test_blob_delete_mem as flaky (#2784)
## Description Only observed on windows, probably because this machine is always slower and triggers some race condition easier. We can change this to be flaky everywhere if we notice it happening on other platforms too. See #2783. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [x] Tests if relevant. - ~~[ ] All breaking changes documented.~~ Co-authored-by: Asmir Avdicevic <asmir.avdicevic64@gmail.com>
1 parent 12f74e2 commit 730f717

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

iroh/src/client/blobs.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,6 +1639,7 @@ mod tests {
16391639
}
16401640

16411641
#[tokio::test]
1642+
#[cfg_attr(target_os = "windows", ignore = "flaky")]
16421643
async fn test_blob_delete_mem() -> Result<()> {
16431644
let _guard = iroh_test::logging::setup();
16441645

0 commit comments

Comments
 (0)