chore: adapt to latest main in iroh-gossip and iroh-docs #2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still not sure if handle_rpc_request should tane an Arc<Self>, but for now just make it work
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2936/docs/iroh/ Last updated: 2024-11-15T16:42:03Z |
dignifiedquire
approved these changes
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adapt to latest main in iroh-gossip and iroh-docs
still not sure if handle_rpc_request should take an
Arc<Self>, but for now just make it workBreaking Changes
none
Notes & open questions
Should all fns that take self take an
Arc<Self>in a protocol handler? The Arc kinda infects the entire code base. But maybe we have to do it.Change checklist